[GitHub] [libcloud] c-w commented on a change in pull request #1584: Optimized 'iterate_container_objects' by filtering the objects before…

[GitBox <gi...@apache.org>]

c-w commented on a change in pull request #1584:
URL: https://github.com/apache/libcloud/pull/1584#discussion_r638812859



##########
File path: libcloud/storage/drivers/local.py
##########
@@ -276,7 +279,7 @@ def iterate_container_objects(self, container, prefix=None,
         """
         prefix = self._normalize_prefix_argument(prefix, ex_prefix)
 
-        objects = self._get_objects(container)
+        objects = self._get_objects(container, prefix)
         return self._filter_listed_container_objects(objects, prefix)

Review comment:
       If we now do the filtering natively in the driver I don't we need the fallback call to `_filter_listed_container_objects` anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org