[jira] [Work logged] (GOBBLIN-1791) Clear flowspec compilation errors on successful compilation if flowspec

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1791?focusedWorklogId=847900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847900 ]

ASF GitHub Bot logged work on GOBBLIN-1791:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Feb/23 00:10
            Start Date: 28/Feb/23 00:10
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3650:
URL: https://github.com/apache/gobblin/pull/3650

   …added specs
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1791
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   When a FlowSpec is compiled through the MultihopFlowCompiler, an error is added for every possible edge where there is at least one property mismatch. The cumulation of these errors for each edge means that from a size perspective there are a lot of strings stored redundantly in the flowspec.
   
   This PR attempts to reduce the size of the FlowSpec, which is stored within the GobblinServiceJobScheduler, by clearing all of the errors from a flowspec if a flow is successfully compiled. Compilation failures are defined when the returned Dag is null
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Unit tests
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 847900)
    Remaining Estimate: 0h
            Time Spent: 10m

> Clear flowspec compilation errors on successful compilation if flowspec
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1791
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1791
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Avoid adding compilation errors to a flowspec if it has been compiled with a valid dag.
> This is to save memory where flowspecs are added to the scheduler, and each flowspec stores its own errors in string form.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)