You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gsmiller (via GitHub)" <gi...@apache.org> on 2023/05/20 15:16:43 UTC

[GitHub] [lucene] gsmiller opened a new issue, #12319: DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection

gsmiller opened a new issue, #12319:
URL: https://github.com/apache/lucene/issues/12319

   ### Description
   
   `DaciukMihovAutomatonBuilder#build` requires sorted input but accepts a `Collection` argument. Since `Collection` generally doesn't guarantee any ordering as part of its contract, we probably ought to use a `List`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection [lucene]

Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed issue #12319: DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection
URL: https://github.com/apache/lucene/issues/12319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] shubhamvishu commented on issue #12319: DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection

Posted by "shubhamvishu (via GitHub)" <gi...@apache.org>.
shubhamvishu commented on issue #12319:
URL: https://github.com/apache/lucene/issues/12319#issuecomment-1627817309

   Raised a PR #12427 for this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org