You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Jeseung Choi (JIRA)" <je...@portals.apache.org> on 2008/10/13 04:16:44 UTC
[jira] Created: (JS2-909) Layout Portlets removed Page logic is
incorrectly worked.
Layout Portlets removed Page logic is incorrectly worked.
---------------------------------------------------------
Key: JS2-909
URL: https://issues.apache.org/jira/browse/JS2-909
Project: Jetspeed 2
Issue Type: Bug
Components: Layout
Affects Versions: 2.1.3
Environment: Window XP, Tomcat 5.5, Java 1.5.x
Reporter: Jeseung Choi
Fix For: 2.2
Layout Portlets removed Page logic is incorrectly worked.
1) login jetspeed-portal.
2) click editPage button.
3) remove current page in page edit pane.
4) browser go to removed page.
5) portal engine does not work correctly.
After inspecting this issue, I came to the following conclusion:
Removed page after parent folder update is problem.
// line 372-387 of MultiColumnPortlet.java
Folder parent = (Folder)requestPage.getParent();
if (parent != null)
{
List orderList = parent.getDocumentOrder();
if (orderList != null)
{
String name = requestPage.getName();
if (orderList.indexOf(name) > -1)
{
orderList.remove(name);
parent.setDocumentOrder(orderList);
pageManager.updateFolder(parent);
}
}
}
pageManager.removePage(requestPage);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-909) Layout Portlets removed Page logic is
incorrectly worked.
Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma reassigned JS2-909:
-----------------------------
Assignee: Woonsan Ko
Woonsan, I've assigned this issue to you as I think it might be related to JS2-832.
> Layout Portlets removed Page logic is incorrectly worked.
> ---------------------------------------------------------
>
> Key: JS2-909
> URL: https://issues.apache.org/jira/browse/JS2-909
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Layout
> Affects Versions: 2.1.3
> Environment: Window XP, Tomcat 5.5, Java 1.5.x
> Reporter: Jeseung Choi
> Assignee: Woonsan Ko
> Fix For: 2.2
>
> Attachments: layout_portlets_remove_patch.patch
>
>
> Layout Portlets removed Page logic is incorrectly worked.
> 1) login jetspeed-portal.
> 2) click editPage button.
> 3) remove current page in page edit pane.
> 4) browser go to removed page.
> 5) portal engine does not work correctly.
> After inspecting this issue, I came to the following conclusion:
> Removed page after parent folder update is problem.
> // line 372-387 of MultiColumnPortlet.java
> Folder parent = (Folder)requestPage.getParent();
> if (parent != null)
> {
> List orderList = parent.getDocumentOrder();
> if (orderList != null)
> {
> String name = requestPage.getName();
> if (orderList.indexOf(name) > -1)
> {
> orderList.remove(name);
> parent.setDocumentOrder(orderList);
> pageManager.updateFolder(parent);
> }
> }
> }
> pageManager.removePage(requestPage);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-909) Layout Portlets removed Page logic is
incorrectly worked.
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko resolved JS2-909.
----------------------------
Resolution: Fixed
A folder should be updated after removing a page.
Thank you very much for the patch, Jeseung Choi!
> Layout Portlets removed Page logic is incorrectly worked.
> ---------------------------------------------------------
>
> Key: JS2-909
> URL: https://issues.apache.org/jira/browse/JS2-909
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Layout
> Affects Versions: 2.1.3
> Environment: Window XP, Tomcat 5.5, Java 1.5.x
> Reporter: Jeseung Choi
> Assignee: Woonsan Ko
> Fix For: 2.2
>
> Attachments: layout_portlets_remove_patch.patch
>
>
> Layout Portlets removed Page logic is incorrectly worked.
> 1) login jetspeed-portal.
> 2) click editPage button.
> 3) remove current page in page edit pane.
> 4) browser go to removed page.
> 5) portal engine does not work correctly.
> After inspecting this issue, I came to the following conclusion:
> Removed page after parent folder update is problem.
> // line 372-387 of MultiColumnPortlet.java
> Folder parent = (Folder)requestPage.getParent();
> if (parent != null)
> {
> List orderList = parent.getDocumentOrder();
> if (orderList != null)
> {
> String name = requestPage.getName();
> if (orderList.indexOf(name) > -1)
> {
> orderList.remove(name);
> parent.setDocumentOrder(orderList);
> pageManager.updateFolder(parent);
> }
> }
> }
> pageManager.removePage(requestPage);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Updated: (JS2-909) Layout Portlets removed Page logic is
incorrectly worked.
Posted by "Jeseung Choi (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeseung Choi updated JS2-909:
-----------------------------
Attachment: layout_portlets_remove_patch.patch
I patched this issue.
> Layout Portlets removed Page logic is incorrectly worked.
> ---------------------------------------------------------
>
> Key: JS2-909
> URL: https://issues.apache.org/jira/browse/JS2-909
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Layout
> Affects Versions: 2.1.3
> Environment: Window XP, Tomcat 5.5, Java 1.5.x
> Reporter: Jeseung Choi
> Fix For: 2.2
>
> Attachments: layout_portlets_remove_patch.patch
>
>
> Layout Portlets removed Page logic is incorrectly worked.
> 1) login jetspeed-portal.
> 2) click editPage button.
> 3) remove current page in page edit pane.
> 4) browser go to removed page.
> 5) portal engine does not work correctly.
> After inspecting this issue, I came to the following conclusion:
> Removed page after parent folder update is problem.
> // line 372-387 of MultiColumnPortlet.java
> Folder parent = (Folder)requestPage.getParent();
> if (parent != null)
> {
> List orderList = parent.getDocumentOrder();
> if (orderList != null)
> {
> String name = requestPage.getName();
> if (orderList.indexOf(name) > -1)
> {
> orderList.remove(name);
> parent.setDocumentOrder(orderList);
> pageManager.updateFolder(parent);
> }
> }
> }
> pageManager.removePage(requestPage);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org