You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/05/05 09:16:16 UTC

[GitHub] [couchdb-fauxton] Neurrone opened a new pull request #1198: Improve Accessibility for screen reader users

Neurrone opened a new pull request #1198: Improve Accessibility for screen reader users
URL: https://github.com/apache/couchdb-fauxton/pull/1198
 
 
   Fixes #1197.
   
   ## Overview
   
   Improve accessibility by adding missing labels and using appropriate roles.
   
   [x] Navigation menu: ensure that nav links are always labelled for screen readers, regardless of whether they are visually minimized. Add labels and roles for the minimize toggle button.
   [x] Make screen readers read incoming notifications, add some missing labels in the notifications panel
   [x] render notifications in a labelled <aside> instead of a <span>
   
   ## Testing recommendations
   
   Run NVDA with Firefox and connect to a fauxton instance.
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services