You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2003/12/22 18:47:43 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml
remm 2003/12/22 09:47:43
Modified: catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java
mbeans-descriptors.xml
Log:
- Add a minTime attribute on servlets.
Revision Changes Path
1.35 +12 -4 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- StandardWrapper.java 15 Oct 2003 18:47:49 -0000 1.34
+++ StandardWrapper.java 22 Dec 2003 17:47:43 -0000 1.35
@@ -1408,6 +1408,14 @@
swValve.setMaxTime(maxTime);
}
+ public long getMinTime() {
+ return swValve.getMinTime();
+ }
+
+ public void setMinTime(long minTime) {
+ swValve.setMinTime(minTime);
+ }
+
public int getRequestCount() {
return swValve.getRequestCount();
}
1.24 +11 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java
Index: StandardWrapperValve.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- StandardWrapperValve.java 15 Oct 2003 18:47:49 -0000 1.23
+++ StandardWrapperValve.java 22 Dec 2003 17:47:43 -0000 1.24
@@ -109,6 +109,7 @@
// are here for performance.
private long processingTime;
private long maxTime;
+ private long minTime = Long.MAX_VALUE;
private int requestCount;
private int errorCount;
@@ -371,6 +372,7 @@
long time=t2-t1;
processingTime += time;
if( time > maxTime) maxTime=time;
+ if( time < minTime) minTime=time;
}
@@ -466,6 +468,14 @@
public void setMaxTime(long maxTime) {
this.maxTime = maxTime;
+ }
+
+ public long getMinTime() {
+ return minTime;
+ }
+
+ public void setMinTime(long minTime) {
+ this.minTime = minTime;
}
public int getRequestCount() {
1.27 +5 -0 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- mbeans-descriptors.xml 30 Nov 2003 14:33:29 -0000 1.26
+++ mbeans-descriptors.xml 22 Dec 2003 17:47:43 -0000 1.27
@@ -772,6 +772,11 @@
type="long"
writeable="false" />
+ <attribute name="minTime"
+ description="Minimum processing time of a request"
+ type="long"
+ writeable="false" />
+
<attribute name="requestCount"
description="Number of requests processed by this wrapper"
type="int"
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml
Posted by Remy Maucherat <re...@apache.org>.
Tim Funk wrote:
> Is there more to this? What is this for?
It gives the minimum amount of time for processing a request for the
servlet. I think this is not 100% useless (but probably very close to),
and I found the idea for the attribute in JBoss (in the JSR 77 code).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core
StandardWrapper.java StandardWrapperValve.java mbeans-descriptors.xml
Posted by Tim Funk <fu...@joedog.org>.
Is there more to this? What is this for?
-Tim
remm@apache.org wrote:
> remm 2003/12/22 09:47:43
>
> Modified: catalina/src/share/org/apache/catalina/core
> StandardWrapper.java StandardWrapperValve.java
> mbeans-descriptors.xml
> Log:
> - Add a minTime attribute on servlets.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org