You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/24 14:13:29 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5073: xtensa/esp32: Fix some Wi-Fi issues

gustavonihei commented on a change in pull request #5073:
URL: https://github.com/apache/incubator-nuttx/pull/5073#discussion_r775025429



##########
File path: boards/xtensa/esp32/esp32-devkitc/src/esp32_reset.c
##########
@@ -24,11 +24,20 @@
 
 #include <nuttx/config.h>
 
+#include <stdlib.h>
+#include <debug.h>
+#include <assert.h>
 #include <nuttx/arch.h>
 #include <nuttx/board.h>
 
+#include "esp32_systemreset.h"
+
 #ifdef CONFIG_BOARDCTL_RESET
 
+#if CONFIG_BOARD_ASSERT_RESET_VALUE == EXIT_SUCCESS
+#  error "CONFIG_BOARD_ASSERT_RESET_VALUE is equal to EXIT_SUCCESS"

Review comment:
       ```suggestion
   #  error "CONFIG_BOARD_ASSERT_RESET_VALUE must not be equal to EXIT_SUCCESS"
   ```
   Suggestion for making the error message clearly state the reason for failure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org