[GitHub] [ozone] bshashikant commented on a change in pull request #2538: HDDS-5619. Ozone data corruption issue on follower node.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #2538:
URL: https://github.com/apache/ozone/pull/2538#discussion_r689607616



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -678,6 +694,19 @@ private ByteString readStateMachineData(
     }
   }
 
+  private void getReadStateMachineFuture(
+      CompletableFuture<ByteString> readStateMachineFuture,
+      ContainerCommandRequestProto requestProto, LogEntryProto entry) {
+    try {
+      readStateMachineFuture.complete(
+          readStateMachineData(requestProto, entry.getTerm(),
+              entry.getIndex()));
+    } catch (IOException e) {
+      metrics.incNumReadStateMachineFails();
+      readStateMachineFuture.completeExceptionally(e);

Review comment:
       stateMachine will be marked unhealthy right at readStateMachineData() call. Similarly, Container will be marked unhealthy in HddsDispatcher if readChunk fails.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org