[GitHub] [incubator-superset] villebro commented on a change in pull request #11107: fix: Disabling timezone of dataframe before passing Prophet

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #11107:
URL: https://github.com/apache/incubator-superset/pull/11107#discussion_r497344751



##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -599,6 +599,7 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
         weekly_seasonality=weekly_seasonality,
         daily_seasonality=daily_seasonality,
     )
+    df["ds"] = df["ds"].dt.tz_convert(None)

Review comment:
       I believe we need to check first if the timezone is set. Can you check to see if this works? (I unfortunately don't have my Druid cluster handy right now)
   ```suggestion
       if df["ds"].dt.tz:
           df["ds"] = df["ds"].dt.tz_convert(None)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org