Review Request 74166: ATLAS-4674 : Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja via Review Board <no...@reviews.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74166/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab and Sidharth Mishra.


Bugs: ATLAS-4674
    https://issues.apache.org/jira/browse/ATLAS-4674


Repository: atlas


Description
-------

When we add/delete a classification from an entity, we send notification to ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based policy. This functionally seems to be broken and is a regression.

On further investigation, it is seen that the issue is caused by deferred action for classification propagation as the right notifications are sent when deferred action is disabled. 

Entity details for the notification messages are fetched from the entity cache which is not updated and lacks the new classification mapping. This patch updates the cache with the most recent entity information after a classification is attached/removed.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 8d306c745 


Diff: https://reviews.apache.org/r/74166/diff/1/


Testing
-------

mvn clean -DskipTests install 
mvn clean -DskipTests package -Pdist,embedded-hbase-solr 
Atlas server running.
Classification add, Classification delete: Verified appropriate messages being received on ATLAS_ENTITIES.


Thanks,

Disha Talreja