You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/11/01 03:05:30 UTC
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3505: Add new interface for Qualitis
casionone commented on code in PR #3505:
URL: https://github.com/apache/incubator-linkis/pull/3505#discussion_r978265011
##########
linkis-public-enhancements/linkis-datasource/linkis-datasource-manager/server/src/main/java/org/apache/linkis/datasourcemanager/core/restful/DataSourceAdminRestfulApi.java:
##########
@@ -111,7 +107,7 @@ public Message insertJsonEnvBatch(
@RequestParam("system") String system,
HttpServletRequest req)
throws ErrorException {
- String userName = SecurityFilter.getLoginUsername(req);
+ String userName = ModuleUserUtils.getOperationUser(req, "rollBackEnginePlugin");
Review Comment:
the action is insertJsonEnvBatch
##########
linkis-public-enhancements/linkis-datasource/linkis-datasource-manager/server/src/main/java/org/apache/linkis/datasourcemanager/core/restful/DataSourceCoreRestfulApi.java:
##########
@@ -687,6 +688,25 @@ public Message connectDataSource(
"Fail to connect data source[连接数据源失败]");
}
+ @ApiOperation(value = "queryDataSourceByIds", notes = "query data source by ids", response = Message.class)
+ @ApiImplicitParams({
+ @ApiImplicitParam(name = "ids", required = true, dataType = "List", value = "ids"),
Review Comment:
Add example value, maybe as "12,23,34"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org