[GitHub] maropu edited a comment on issue #23854: [SPARK-22000][SQL] Use String.valueOf in generated code to assign value to String type of field in Java Bean Encoder

[GitBox <gi...@apache.org>]

maropu edited a comment on issue #23854: [SPARK-22000][SQL] Use String.valueOf in generated code to assign value to String type of field in Java Bean Encoder
URL: https://github.com/apache/spark/pull/23854#issuecomment-466238643
 
 
   btw, why don't we cast internal data into more suitable typed data before deserializing them into Bean instead of this weird type handling like int-> string in deserializer?
   
   Probably, it seems we can add cast exprs before collecting data?
   https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L3360

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org