[GitHub] [ignite-3] rpuch commented on a diff in pull request #873: IGNITE-17144 Fix parsing of alpha versions of Ignite

[GitBox <gi...@apache.org>]

rpuch commented on code in PR #873:
URL: https://github.com/apache/ignite-3/pull/873#discussion_r893387839


##########
modules/core/src/main/java/org/apache/ignite/internal/properties/IgniteProductVersion.java:
##########
@@ -47,11 +48,15 @@ public class IgniteProductVersion implements Serializable {
     /** Flag indicating if this is a snapshot release. */
     private final boolean isSnapshot;
 
-    private IgniteProductVersion(byte major, byte minor, byte maintenance, boolean isSnapshot) {
+    /** Alpha version part or an empty string if this is not an alpha release. */
+    private final String alphaVersion;

Review Comment:
   What if at some point we switch to beta versions? Should we generalize over 'alpha|beta|rc|...'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org