You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/02 21:01:35 UTC
[GitHub] [superset] yardz opened a new pull request #13941: test: Tabs
yardz opened a new pull request #13941:
URL: https://github.com/apache/superset/pull/13941
### SUMMARY
Test for Tabs component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a change in pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #13941:
URL: https://github.com/apache/superset/pull/13941#discussion_r606528299
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
##########
@@ -0,0 +1,235 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
+import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
+import DeleteComponentButton from 'src/dashboard/components/DeleteComponentButton';
+import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath';
+
+import Tabs from './Tabs';
+
+jest.mock('src/dashboard/containers/DashboardComponent', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ onClick={() =>
+ props.onDropOnTab({ destination: { id: 'TAB-YT6eNksV-' } })
+ }
+ data-test="DashboardComponent"
+ >
+ DashboardComponent
+ </button>
+ )),
+);
+
+jest.mock('src/dashboard/components/DeleteComponentButton', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ data-test="DeleteComponentButton"
+ onClick={props.onDelete}
+ >
+ DeleteComponentButton
+ </button>
+ )),
+);
+jest.mock('src/dashboard/util/getLeafComponentIdFromPath', () => jest.fn());
+
+jest.mock('src/dashboard/components/dnd/DragDroppable', () =>
+ jest.fn(props => {
+ const childProps = props.editMode
+ ? {
+ dragSourceRef: props.dragSourceRef,
+ dropIndicatorProps: props.dropIndicatorProps,
+ }
+ : {};
+ return (
+ <div>
+ <button type="button" data-test="DragDroppable" onClick={props.onDrop}>
+ DragDroppable
+ </button>
+ {props.children(childProps)}
+ </div>
+ );
+ }),
+);
+
+const creteProps = () => ({
Review comment:
spelling nit: createProps
Also why does this need to be a function. There are not paramerters being passed in or reassignments. Does it make sense to make this an object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz closed pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
yardz closed pull request #13941:
URL: https://github.com/apache/superset/pull/13941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-814266679
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (66378d3) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 77.79% +1.25%
==========================================
Files 934 934
Lines 47393 47350 -43
Branches 5964 5948 -16
==========================================
+ Hits 36276 36836 +560
+ Misses 10939 10354 -585
+ Partials 178 160 -18
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.53% <ø> (+5.17%)` | :arrow_up: |
| javascript | `66.41% <ø> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `59.74% <0.00%> (-16.24%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `49.27% <0.00%> (-6.77%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `80.00% <0.00%> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `54.54% <0.00%> (-2.28%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-1.36%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.06% <0.00%> (-0.78%)` | :arrow_down: |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.56% <0.00%> (-0.31%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <0.00%> (ø)` | |
| ... and [91 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...66378d3](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (66378d3) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.73%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 66378d3 differs from pull request most recent head bdcd289. Consider uploading reports for the commit bdcd289 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.28% +1.73%
==========================================
Files 934 934
Lines 47393 47350 -43
Branches 5964 5948 -16
==========================================
+ Hits 36276 37066 +790
+ Misses 10939 10140 -799
+ Partials 178 144 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+7.67%)` | :arrow_up: |
| javascript | `66.41% <ø> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.56% <0.00%> (-0.31%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <0.00%> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <0.00%> (+0.47%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.95% <0.00%> (+0.82%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `61.25% <0.00%> (+1.25%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `73.58% <0.00%> (+1.25%)` | :arrow_up: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `98.71% <0.00%> (+1.28%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <0.00%> (+1.38%)` | :arrow_up: |
| ... and [105 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...bdcd289](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (66378d3) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 76.56% +0.02%
==========================================
Files 934 934
Lines 47393 47348 -45
Branches 5964 5948 -16
==========================================
- Hits 36276 36252 -24
+ Misses 10939 10917 -22
- Partials 178 179 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.41% <ø> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <0.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `94.69% <0.00%> (+3.60%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `88.42% <0.00%> (+13.68%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...66378d3](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (2395fa9) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `0.88%`.
> The diff coverage is `89.65%`.
> :exclamation: Current head 2395fa9 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 77.42% +0.88%
==========================================
Files 934 936 +2
Lines 47393 47385 -8
Branches 5964 5967 +3
==========================================
+ Hits 36276 36689 +413
+ Misses 10939 10536 -403
+ Partials 178 160 -18
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.48% <73.17%> (+2.12%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.97% <92.59%> (+0.68%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `96.92% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `60.00% <ø> (ø)` | |
| [...ols/FilterControl/AdhocFilterEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIvaW5kZXguanN4) | `66.00% <ø> (ø)` | |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LmpzeA==) | `77.48% <ø> (ø)` | |
| ... and [138 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (2395fa9) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.77%`.
> The diff coverage is `89.65%`.
> :exclamation: Current head 2395fa9 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.31% +1.77%
==========================================
Files 934 936 +2
Lines 47393 47385 -8
Branches 5964 5967 +3
==========================================
+ Hits 36276 37110 +834
+ Misses 10939 10133 -806
+ Partials 178 142 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <73.17%> (+7.68%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.97% <92.59%> (+0.68%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `96.92% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `60.00% <ø> (ø)` | |
| [...ols/FilterControl/AdhocFilterEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIvaW5kZXguanN4) | `66.00% <ø> (ø)` | |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LmpzeA==) | `77.48% <ø> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (2395fa9) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.03%`.
> The diff coverage is `89.65%`.
> :exclamation: Current head 2395fa9 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 77.57% +1.03%
==========================================
Files 934 950 +16
Lines 47393 48116 +723
Branches 5964 6174 +210
==========================================
+ Hits 36276 37325 +1049
+ Misses 10939 10650 -289
+ Partials 178 141 -37
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `66.97% <92.59%> (+0.68%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `96.92% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
| [...ols/FilterControl/AdhocFilterEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIvaW5kZXguanN4) | `66.00% <ø> (ø)` | |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LmpzeA==) | `77.48% <ø> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (66378d3) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.28% +1.73%
==========================================
Files 934 934
Lines 47393 47350 -43
Branches 5964 5948 -16
==========================================
+ Hits 36276 37066 +790
+ Misses 10939 10140 -799
+ Partials 178 144 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+7.67%)` | :arrow_up: |
| javascript | `66.41% <ø> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.56% <0.00%> (-0.31%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <0.00%> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <0.00%> (+0.47%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.95% <0.00%> (+0.82%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `61.25% <0.00%> (+1.25%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `73.58% <0.00%> (+1.25%)` | :arrow_up: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `98.71% <0.00%> (+1.28%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <0.00%> (+1.38%)` | :arrow_up: |
| ... and [105 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...66378d3](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (7d3c410) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.57%`.
> The diff coverage is `86.36%`.
> :exclamation: Current head 7d3c410 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.11% +1.57%
==========================================
Files 934 934
Lines 47393 47352 -41
Branches 5964 5952 -12
==========================================
+ Hits 36276 36989 +713
+ Misses 10939 10219 -720
+ Partials 178 144 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `66.45% <86.36%> (+0.16%)` | :arrow_up: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `74.10% <66.66%> (-0.17%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.45% <71.42%> (+7.36%)` | :arrow_up: |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <100.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (+11.11%)` | :arrow_up: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.02% <100.00%> (+9.11%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| ... and [123 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-813647552
@junlincc Ephemeral environment spinning up at http://52.38.130.102:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a change in pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #13941:
URL: https://github.com/apache/superset/pull/13941#discussion_r606528299
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
##########
@@ -0,0 +1,235 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
+import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
+import DeleteComponentButton from 'src/dashboard/components/DeleteComponentButton';
+import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath';
+
+import Tabs from './Tabs';
+
+jest.mock('src/dashboard/containers/DashboardComponent', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ onClick={() =>
+ props.onDropOnTab({ destination: { id: 'TAB-YT6eNksV-' } })
+ }
+ data-test="DashboardComponent"
+ >
+ DashboardComponent
+ </button>
+ )),
+);
+
+jest.mock('src/dashboard/components/DeleteComponentButton', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ data-test="DeleteComponentButton"
+ onClick={props.onDelete}
+ >
+ DeleteComponentButton
+ </button>
+ )),
+);
+jest.mock('src/dashboard/util/getLeafComponentIdFromPath', () => jest.fn());
+
+jest.mock('src/dashboard/components/dnd/DragDroppable', () =>
+ jest.fn(props => {
+ const childProps = props.editMode
+ ? {
+ dragSourceRef: props.dragSourceRef,
+ dropIndicatorProps: props.dropIndicatorProps,
+ }
+ : {};
+ return (
+ <div>
+ <button type="button" data-test="DragDroppable" onClick={props.onDrop}>
+ DragDroppable
+ </button>
+ {props.children(childProps)}
+ </div>
+ );
+ }),
+);
+
+const creteProps = () => ({
Review comment:
spelling nit: createProps
Also why does this need to be a function. There are no paramerters being passed in or reassignments. Does it make sense to make this an object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-813534444
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13941:
URL: https://github.com/apache/superset/pull/13941#discussion_r607095564
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
##########
@@ -0,0 +1,235 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
+import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
+import DeleteComponentButton from 'src/dashboard/components/DeleteComponentButton';
+import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath';
+
+import Tabs from './Tabs';
+
+jest.mock('src/dashboard/containers/DashboardComponent', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ onClick={() =>
+ props.onDropOnTab({ destination: { id: 'TAB-YT6eNksV-' } })
+ }
+ data-test="DashboardComponent"
+ >
+ DashboardComponent
+ </button>
+ )),
+);
+
+jest.mock('src/dashboard/components/DeleteComponentButton', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ data-test="DeleteComponentButton"
+ onClick={props.onDelete}
+ >
+ DeleteComponentButton
+ </button>
+ )),
+);
+jest.mock('src/dashboard/util/getLeafComponentIdFromPath', () => jest.fn());
+
+jest.mock('src/dashboard/components/dnd/DragDroppable', () =>
+ jest.fn(props => {
+ const childProps = props.editMode
+ ? {
+ dragSourceRef: props.dragSourceRef,
+ dropIndicatorProps: props.dropIndicatorProps,
+ }
+ : {};
+ return (
+ <div>
+ <button type="button" data-test="DragDroppable" onClick={props.onDrop}>
+ DragDroppable
+ </button>
+ {props.children(childProps)}
+ </div>
+ );
+ }),
+);
+
+const creteProps = () => ({
Review comment:
Fixed!
We talked about this in another PR: https://github.com/apache/superset/pull/13753#discussion_r600862661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13941:
URL: https://github.com/apache/superset/pull/13941#discussion_r607247709
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
##########
@@ -0,0 +1,235 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
+import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
+import DeleteComponentButton from 'src/dashboard/components/DeleteComponentButton';
+import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath';
+
+import Tabs from './Tabs';
+
+jest.mock('src/dashboard/containers/DashboardComponent', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ onClick={() =>
+ props.onDropOnTab({ destination: { id: 'TAB-YT6eNksV-' } })
+ }
+ data-test="DashboardComponent"
+ >
+ DashboardComponent
+ </button>
+ )),
+);
+
+jest.mock('src/dashboard/components/DeleteComponentButton', () =>
+ jest.fn(props => (
+ <button
+ type="button"
+ data-test="DeleteComponentButton"
+ onClick={props.onDelete}
+ >
+ DeleteComponentButton
+ </button>
+ )),
+);
+jest.mock('src/dashboard/util/getLeafComponentIdFromPath', () => jest.fn());
+
+jest.mock('src/dashboard/components/dnd/DragDroppable', () =>
+ jest.fn(props => {
+ const childProps = props.editMode
+ ? {
+ dragSourceRef: props.dragSourceRef,
+ dropIndicatorProps: props.dropIndicatorProps,
+ }
+ : {};
+ return (
+ <div>
+ <button type="button" data-test="DragDroppable" onClick={props.onDrop}>
+ DragDroppable
+ </button>
+ {props.children(childProps)}
+ </div>
+ );
+ }),
+);
+
+const createProps = () => ({
+ id: 'TABS-L-d9eyOE-b',
+ parentId: 'GRID_ID',
+ depth: 2,
+ index: 0,
+ availableColumnCount: 12,
+ columnWidth: 120,
+ isComponentVisible: true,
+ component: {
+ children: ['TAB-AsMaxdYL_t', 'TAB-YT6eNksV-', 'TAB-l_9I0aNYZ'],
+ id: 'TABS-L-d9eyOE-b',
+ meta: {},
+ parents: ['ROOT_ID', 'GRID_ID'],
+ type: 'TABS',
+ },
+ parentComponent: {
+ children: ['TABS-L-d9eyOE-b'],
+ id: 'GRID_ID',
+ parents: ['ROOT_ID'],
+ type: 'GRID',
+ },
+ editMode: true,
+ undoLength: 0,
+ redoLength: 0,
+ filters: {},
+ directPathToChild: [],
+ directPathLastUpdated: 1617395480760,
+ dashboardId: 23,
+ focusedFilterScope: null,
+ renderTabContent: true,
+ renderHoverMenu: true,
+ logEvent: jest.fn(),
+ createComponent: jest.fn(),
+ handleComponentDrop: jest.fn(),
+ onChangeTab: jest.fn(),
+ deleteComponent: jest.fn(),
+ updateComponents: jest.fn(),
+});
+
+beforeEach(() => {
+ jest.clearAllMocks();
+});
+
+test('Should render editMode:true', () => {
+ const props = createProps();
+ render(<Tabs {...props} />, { useRedux: true, useDnd: true });
+ expect(screen.getAllByRole('tab')).toHaveLength(3);
+ expect(DragDroppable).toBeCalledTimes(1);
+ expect(DashboardComponent).toBeCalledTimes(4);
+ expect(DeleteComponentButton).toBeCalledTimes(1);
+ expect(screen.getAllByRole('button', { name: 'remove' })).toHaveLength(3);
+ expect(screen.getAllByRole('button', { name: 'Add tab' })).toHaveLength(2);
+});
+
+test('Should render editMode:false', () => {
+ const props = createProps();
+ props.editMode = false;
+ render(<Tabs {...props} />, { useRedux: true, useDnd: true });
+ expect(screen.getAllByRole('tab')).toHaveLength(3);
+ expect(DragDroppable).toBeCalledTimes(1);
+ expect(DashboardComponent).toBeCalledTimes(4);
+ expect(DeleteComponentButton).not.toBeCalled();
+ expect(
+ screen.queryByRole('button', { name: 'remove' }),
+ ).not.toBeInTheDocument();
+ expect(
+ screen.queryByRole('button', { name: 'Add tab' }),
+ ).not.toBeInTheDocument();
+});
+
+test('Update component props', () => {
+ const props = createProps();
+ (getLeafComponentIdFromPath as jest.Mock).mockResolvedValueOnce('none');
+ props.editMode = false;
+ const { rerender } = render(<Tabs {...props} />, {
+ useRedux: true,
+ useDnd: true,
+ });
+ expect(DeleteComponentButton).not.toBeCalled();
+
+ props.editMode = true;
+ rerender(<Tabs {...props} />);
+ expect(DeleteComponentButton).toBeCalledTimes(1);
+});
+
+test('Clicking on "DeleteComponentButton"', () => {
+ const props = createProps();
+ render(<Tabs {...props} />, {
+ useRedux: true,
+ useDnd: true,
+ });
+
+ expect(props.deleteComponent).not.toBeCalled();
+ userEvent.click(screen.getByTestId('DeleteComponentButton'));
+ expect(props.deleteComponent).toBeCalledWith('TABS-L-d9eyOE-b', 'GRID_ID');
+});
+
+test('Add new tab', () => {
+ const props = createProps();
+ render(<Tabs {...props} />, {
+ useRedux: true,
+ useDnd: true,
+ });
+
+ expect(props.createComponent).not.toBeCalled();
+ userEvent.click(screen.getAllByRole('button', { name: 'Add tab' })[0]);
+ expect(props.createComponent).toBeCalled();
+});
+
+test('Removing a tab', async () => {
+ const props = createProps();
+ render(<Tabs {...props} />, {
+ useRedux: true,
+ useDnd: true,
+ });
+
+ expect(props.deleteComponent).not.toBeCalled();
+ expect(screen.queryByText('Delete dashboard tab?')).not.toBeInTheDocument();
+ userEvent.click(screen.getAllByRole('button', { name: 'remove' })[0]);
+ expect(props.deleteComponent).not.toBeCalled();
+
+ await waitFor(() => {
+ expect(screen.getByText('Delete dashboard tab?')).toBeInTheDocument();
+ });
Review comment:
```suggestion
expect(await screen.findByText('Delete dashboard tab?')).toBeInTheDocument();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (61c6017) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.39%`.
> The diff coverage is `88.79%`.
> :exclamation: Current head 61c6017 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 77.93% +1.39%
==========================================
Files 934 935 +1
Lines 47393 47375 -18
Branches 5964 5964
==========================================
+ Hits 36276 36923 +647
+ Misses 10939 10295 -644
+ Partials 178 157 -21
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `67.24% <90.17%> (+0.95%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <ø> (ø)` | |
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `96.92% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `60.00% <ø> (ø)` | |
| ... and [151 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (2395fa9) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.77%`.
> The diff coverage is `89.65%`.
> :exclamation: Current head 2395fa9 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.31% +1.77%
==========================================
Files 934 936 +2
Lines 47393 47385 -8
Branches 5964 5967 +3
==========================================
+ Hits 36276 37110 +834
+ Misses 10939 10133 -806
+ Partials 178 142 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <73.17%> (+7.68%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.97% <92.59%> (+0.68%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...components/controls/FilterBoxItemControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC9pbmRleC5qc3g=) | `73.58% <ø> (ø)` | |
| [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `96.92% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `60.00% <ø> (ø)` | |
| [...ols/FilterControl/AdhocFilterEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIvaW5kZXguanN4) | `66.00% <ø> (ø)` | |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LmpzeA==) | `77.48% <ø> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...143a3d4](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13941:
URL: https://github.com/apache/superset/pull/13941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13941: test: Tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13941:
URL: https://github.com/apache/superset/pull/13941#issuecomment-812720462
# [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=h1) Report
> Merging [#13941](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=desc) (7d3c410) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.57%`.
> The diff coverage is `86.36%`.
> :exclamation: Current head 7d3c410 differs from pull request most recent head bdcd289. Consider uploading reports for the commit bdcd289 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
+ Coverage 76.54% 78.11% +1.57%
==========================================
Files 934 934
Lines 47393 47352 -41
Branches 5964 5952 -12
==========================================
+ Hits 36276 36989 +713
+ Misses 10939 10219 -720
+ Partials 178 144 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `66.45% <86.36%> (+0.16%)` | :arrow_up: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `74.10% <66.66%> (-0.17%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.45% <71.42%> (+7.36%)` | :arrow_up: |
| [...tend/src/SqlLab/components/SouthPane/SouthPane.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9Tb3V0aFBhbmUudHN4) | `79.54% <100.00%> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (+11.11%)` | :arrow_up: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.02% <100.00%> (+9.11%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| ... and [123 more](https://codecov.io/gh/apache/superset/pull/13941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=footer). Last update [1d8d067...bdcd289](https://codecov.io/gh/apache/superset/pull/13941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org