You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/01 13:47:28 UTC
[GitHub] [arrow] assignUser opened a new pull request, #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
assignUser opened a new pull request, #13284:
URL: https://github.com/apache/arrow/pull/13284
@kszucs @raulcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1145843339
With the removal of the auth for archery in https://github.com/apache/arrow/pull/13283 shouldn't pop up anymore.
I looked into the code a bit and if I understand correctly the error pops up because the `Jira` instance is created in line 800 within the `release` command which is executed and passes the `obj` to the subcommand `curate|changelog|cherrypick`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs merged pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
kszucs merged PR #13284:
URL: https://github.com/apache/arrow/pull/13284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1144872942
Hmm, not sure this is tied to this PR, but `curate --help` displays a wall of errors for me:
```
$ archery release curate --help
Traceback (most recent call last):
File "/home/antoine/miniconda3/envs/pyarrow/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 1654, in invoke
super().invoke(ctx)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/click/decorators.py", line 38, in new_func
return f(get_current_context().obj, *args, **kwargs)
File "/home/antoine/arrow/dev/dev/archery/archery/cli.py", line 800, in release
jira = Jira()
File "/home/antoine/arrow/dev/dev/archery/archery/release.py", line 92, in __init__
super().__init__(url, basic_auth=(user, password))
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/client.py", line 506, in __init__
si = self.server_info()
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/client.py", line 2551, in server_info
j = self._get_json("serverInfo")
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/client.py", line 3139, in _get_json
r = self._session.get(url, params=params)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/resilientsession.py", line 172, in get
return self.__verb("GET", url, **kwargs)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/resilientsession.py", line 168, in __verb
raise_on_error(response, verb=verb, **kwargs)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.9/site-packages/jira/resilientsession.py", line 53, in raise_on_error
raise JIRAError(
jira.exceptions.JIRAError: JiraError HTTP 403 url: https://issues.apache.org/jira/rest/api/2/serverInfo
text: CAPTCHA_CHALLENGE; login-url=https://issues.apache.org/jira/login.jsp
response headers = {'Date': 'Thu, 02 Jun 2022 13:33:26 GMT', 'Server': 'Apache', 'X-AREQUESTID': '813x81395242x3', 'Referrer-Policy': 'strict-origin-when-cross-origin', 'X-XSS-Protection': '1; mode=block', 'X-Content-Type-Options': 'nosniff', 'X-Frame-Options': 'SAMEORIGIN', 'Content-Security-Policy': "frame-ancestors 'self'", 'Strict-Transport-Security': 'max-age=31536000', 'X-Seraph-LoginReason': 'AUTHENTICATION_DENIED', 'WWW-Authenticate': 'OAuth realm="https%3A%2F%2Fissues.apache.org%2Fjira"', 'X-ASESSIONID': '9zelgi', 'X-Authentication-Denied-Reason': 'CAPTCHA_CHALLENGE; login-url=https://issues.apache.org/jira/login.jsp', 'Content-Type': 'text/html;charset=UTF-8', 'Set-Cookie': 'JSESSIONID=147E5C791C0171C5B3DC695A9514FD5F; Path=/jira; Secure; HttpOnly', 'Via': '1.1 jira2-he-de.apache.org', 'Keep-Alive': 'timeout=15, max=100', 'Connection': 'Keep-Alive', 'Transfer-Encoding': 'chunked'}
response text =
<html>
<head>
<title>Forbidden (403)</title>
[ etc. ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887958263
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
We use both already :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887953314
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
~~That would be possible but throughout archery the double-flag syntax is used: I think it would be better to stick to that convention for consistency.~~
I just noticed that we use both... so 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1148442277
@pitrou I rebased and tested, `--help` now works without the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1145776891
I have no idea, TBH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r886886635
##########
dev/archery/archery/release.py:
##########
@@ -89,7 +89,7 @@ def __init__(self, user=None, password=None,
url='https://issues.apache.org/jira'):
user = user or os.environ.get('APACHE_JIRA_USER')
password = password or os.environ.get('APACHE_JIRA_PASSWORD')
- super().__init__(url, basic_auth=(user, password))
+ super().__init__(url, token_auth=password)
Review Comment:
This change belongs to the JIRA token PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887825050
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
This looks weird: should I pass `--minimal` or `--full` to get the desired effect? Especially as the default is... False (what does it mean?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r891028774
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
Since we have multiple occurrences this can be done in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r886853056
##########
dev/archery/archery/release.py:
##########
@@ -390,7 +390,7 @@ def commits(self):
commit_range = f"{lower}..{upper}"
return list(map(Commit, self.repo.iter_commits(commit_range)))
- def curate(self):
+ def curate(self, minimal):
Review Comment:
this will fail on line 421 as we are calling `self.curate()` without any argument and you are expecting one now. One way of avoiding this on python is specifying a default that maintains previous behaviour:
```suggestion
def curate(self, minimal=False):
```
Whith this we avoid the failure.
##########
dev/archery/archery/release.py:
##########
@@ -412,7 +412,7 @@ def curate(self):
if key not in within_keys]
return ReleaseCuration(release=self, within=within, outside=outside,
Review Comment:
I would have expected `ReleaseCuration` to require a new field `minimal` defined. Line 244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r886867104
##########
dev/archery/archery/release.py:
##########
@@ -412,7 +412,7 @@ def curate(self):
if key not in within_keys]
return ReleaseCuration(release=self, within=within, outside=outside,
Review Comment:
Yeah I thought so too but the fields are just set as `self._data` and passed through to the jinja renderer see [here](https://github.com/apache/arrow/blob/3830f05a2b6f354437b50e66f65a1578eebfc693/dev/archery/archery/utils/report.py#L32-L36) and are then available as jinja variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887837348
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
I agree it looks a bit weird. If you don't pass `--minimal` the full version will be printed.
By default, [click expects](https://click.palletsprojects.com/en/7.x/options/#boolean-flags) an on-flag and an off-flag for boolean flags, so they translate to `True/False` and `default=False` -> we pass `--full` by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r886961207
##########
dev/archery/archery/release.py:
##########
@@ -89,7 +89,7 @@ def __init__(self, user=None, password=None,
url='https://issues.apache.org/jira'):
user = user or os.environ.get('APACHE_JIRA_USER')
password = password or os.environ.get('APACHE_JIRA_PASSWORD')
- super().__init__(url, basic_auth=(user, password))
+ super().__init__(url, token_auth=password)
Review Comment:
ah commited by accident
```suggestion
super().__init__(url, basic_auth=(user, password))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r891015946
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
It's really just a confusing feature of click, so +1 on `is_flag`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1143666491
Thanks for the changes @assignUser !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887948539
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
Maybe a better option for clarity would be to make it a flag:
```
@click.option('--minimal', is_flag=True, default=False,
help='Only show minimal curate report.')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13284:
URL: https://github.com/apache/arrow/pull/13284#discussion_r887953314
##########
dev/archery/archery/cli.py:
##########
@@ -807,13 +807,15 @@ def release(obj, src, jira_cache):
@release.command('curate')
@click.argument('version')
+@click.option('--minimal/--full', '-m/-f',
Review Comment:
That would be possible but throughout archery the double-flag syntax is used:
I think it would be better to stick to that convention for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1145092137
@pitrou I don't know why click would trigger the command when `--help` is passed, I don't think it's supposed to work like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1143640115
https://issues.apache.org/jira/browse/ARROW-16663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13284: ARROW-16663: [Release][Dev] Add flag to archery release curate to only show minimal information
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13284:
URL: https://github.com/apache/arrow/pull/13284#issuecomment-1143815483
it looks good to me now, there's a small fix required for the linter to pass though:
```
$ archery lint --python
INFO:archery:Running Python formatter (autopep8)
INFO:archery:Running Python linter (flake8)
/home/raulcd/code/arrow/dev/archery/archery/release.py:416:80: E501 line too long (96 > 79 characters)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org