You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/13 18:57:41 UTC

[jira] [Commented] (FELIX-5589) reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl

    [ https://issues.apache.org/jira/browse/FELIX-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922731#comment-15922731 ] 

ASF GitHub Bot commented on FELIX-5589:
---------------------------------------

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/felix/pull/97

    [FELIX-5589] Optimize Memory usage of empty bundle requirements/capab…

    …ilities

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/felix FELIX-5589

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit 640428095b73c3c92831c0ec7a486482cef01286
Author: Fabian Lange <la...@gmail.com>
Date:   2017-03-13T18:55:08Z

    [FELIX-5589] Optimize Memory usage of empty bundle requirements/capabilities

----


> reduce memory usage of BundleRequirementImpl / BundleCapabilityImpl
> -------------------------------------------------------------------
>
>                 Key: FELIX-5589
>                 URL: https://issues.apache.org/jira/browse/FELIX-5589
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>            Reporter: Fabian Lange
>            Priority: Minor
>         Attachments: Screen Shot 2017-03-13 at 19.52.55.png
>
>
> Currently BundleRequirementImpl and BundleCapabilityImpl might allocate new immutable maps when params are empty. This was pointed out by a profiling session.
> the fix is easy: use Collections.EMPTY_MAP
> (pr coming)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)