You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/13 13:31:37 UTC

[GitHub] [beam] steveniemitz commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

steveniemitz commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.
URL: https://github.com/apache/beam/pull/11350#discussion_r407479202
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
 ##########
 @@ -591,7 +591,7 @@ public void flushState() {
               timerId,
               "",
               cleanupTime,
-              cleanupTime,
+              window.maxTimestamp(),
 
 Review comment:
   this should be `window.maxTimestamp() + allowedLateness` I think?  cleanupTime here is passed in as `maxTimestamp + allowedLateness + 1ms`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services