You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2012/10/09 16:11:02 UTC

[jira] [Created] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Hiram Chirino created PROTON-65:
-----------------------------------

             Summary: Provide a AMQP 1.0 Message to JMS Message mapping logic/module
                 Key: PROTON-65
                 URL: https://issues.apache.org/jira/browse/PROTON-65
             Project: Qpid Proton
          Issue Type: New Feature
          Components: proton-j
            Reporter: Hiram Chirino


Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino updated PROTON-65:
--------------------------------

    Attachment:     (was: PROTON-65.patch)
    
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>            Assignee: Rob Godfrey
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472451#comment-13472451 ] 

Hiram Chirino commented on PROTON-65:
-------------------------------------

Hi Rajith,

The way the patch is setup, the logic creates a new proton-jms module so that JMS is not added as a dependency to the proton-j module.  Please try out the patch and let me know what you think.


                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino updated PROTON-65:
--------------------------------

    Attachment: PROTON-65.patch

Attaching new re-worked impl.  It now lands under the contrib dir.
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>            Assignee: Rob Godfrey
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473305#comment-13473305 ] 

Rob Godfrey commented on PROTON-65:
-----------------------------------

I agree that right now we haven't identified the right place. One of the things that I think needs to be urgently addressed is defining the scope of what is "proton", how we structure to potentially accept intergations of proton, and where we place other code that utilises proton but is non-core.

I know some people are supposed to be writing a "constitution" for Proton at the moment... hopefully over the next week or so we can get agreement on this and find an agreed home for code such ass this.
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503802#comment-13503802 ] 

Hiram Chirino commented on PROTON-65:
-------------------------------------

Now that PROTON-140 has been applied, I'll rework this patch so that it lives under the contrib dir.
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>            Assignee: Rob Godfrey
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafael H. Schloming updated PROTON-65:
--------------------------------------

    Assignee: Rob Godfrey
    
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>            Assignee: Rob Godfrey
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472561#comment-13472561 ] 

Hiram Chirino commented on PROTON-65:
-------------------------------------

If it's not at proton, your encouraging proton users to implement it themselves in potentially incompatible ways.  IMHO I think that would be very bad for folks Adopting AMQP and JMS.  
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Ted Ross (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Ross resolved PROTON-65.
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.3
    
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>            Assignee: Rob Godfrey
>             Fix For: 0.3
>
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472673#comment-13472673 ] 

Rob Godfrey commented on PROTON-65:
-----------------------------------

I think it's more of a module/scoping question.

I completely agree that we should have a JMS <-> Message adapter, hosted within Apache Qpid.  The question is really about the scope of "Proton" as a sub-component of Qpid I think.  One thing that a lot of us a very keen to ensure is that "Proton" is seen as a whole not as a whole load of independent language specific modules (since treating each language independently has caused us many issues in the past).

                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472540#comment-13472540 ] 

Rajith Attapattu commented on PROTON-65:
----------------------------------------

Hiram,

First of all, thx for confirming that it's indeed a separate jar. I figured it was the case, but wasn't too sure given that I haven't messed with mvn for long.

I certainly see the value of having a mapping btw the AMQP message <---> JMS Message and make it available for other folks to use it.
But I'm not sure if proton is the right place to have it.

Now to be fair to you, this is a discussion that goes beyond this particular issue.
We have to make a clear statement about what proton is and what proton is not.

Based on the discussions we had so far about the goals of proton, this doesn't seem to fit in well.
IMO this is something that is best housed at Qpid (or even ActiveMQ for the time being).

Again this is only my opinion. I would talk to other folks as well to see what they think about this.

Regards,

Rajith
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472449#comment-13472449 ] 

Rajith Attapattu commented on PROTON-65:
----------------------------------------

Hiram,

One of the goals of proton is to be as as dependency free as possible, so it can be used in as many environments as possible.
>From that pov I don't think this is a good idea at all.

For example, having the jms library as a dependency will be a big issue in using proton-j in Android (or similar environments). 

On the other hand if we can make this as a separate optional jar (maybe thats what you are doing in this patch, and I haven't messed with maven for ages) then that maybe acceptable.
But still I'm not too comfortable with the idea. I'm not too sure if proton is the place to do so.

I would like to see comments from other interested parties about this.

Regards,

Rajith
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473283#comment-13473283 ] 

Hiram Chirino commented on PROTON-65:
-------------------------------------

The problem is that I can't think of any better place to put it.  A proton-jms module has a tight coupling with currently un-released proton-j module.  Having both those modules build and release together makes more sense than not.
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-65) Provide a AMQP 1.0 Message to JMS Message mapping logic/module

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino updated PROTON-65:
--------------------------------

    Attachment: PROTON-65.patch

Attaching patch that implements the jms mapping.  It adds a new proton-jms modules.  This depends on the PROTON-35 patch being applied first.
                
> Provide a AMQP 1.0 Message to JMS Message mapping logic/module
> --------------------------------------------------------------
>
>                 Key: PROTON-65
>                 URL: https://issues.apache.org/jira/browse/PROTON-65
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-65.patch
>
>
> Having a easy/consistent way to transform a JMS message to an AMQP message and back would be super handy.  Having that logic live in proton would help make that mapping more standardized as different client and sever implementations can just re-use the logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira