You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "yuseok89 (via GitHub)" <gi...@apache.org> on 2026/10/18 15:16:37 UTC

[PR] UI: Add regression tests for Dags list rows remounting on refresh [airflow]

yuseok89 opened a new pull request, #75005:
URL: https://github.com/apache/airflow/pull/75005

<!--
Thank you for contributing!

Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/

Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.

For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.

Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.

In case of an existing issue, reference it using one of the following:

* closes: #ISSUE
* related: #ISSUE
-->

#69619 made the Dags list remount every row whenever the list auto-refreshed with active runs, since the cell renderers were recreated together with the run state counts. Besides the flicker fixed in #74426, I found that the remount also closed the dialog opened from the pause toggle at the next refresh, so it could close before the user chose between pausing and draining. #74426 fixed both by moving the renderers to module level.

This adds tests to keep the regression from coming back. They render the Dags list with a running Dag, let it auto-refresh with changing run state counts, and check both symptoms in the card and table views.

- The rows are not remounted, so the pause toggle is still the same DOM node after a refresh.
- The pause or drain dialog opened from the toggle stays open across a refresh.

Each test fails on the code before #74426 and passes on main. The tests lower `auto_refresh_interval` to one second, so each one takes about 1.2s.

related: #69619, #74426

---

##### Was generative AI tooling used to co-author this PR?

- [x] Yes (please specify the tool below)
- Claude Code (Opus 5.5)

---

* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] UI: Add regression tests for Dags list rows remounting on refresh [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.

bbovenzi commented on PR #75005:
URL: https://github.com/apache/airflow/pull/75005#issuecomment-6277912047

   Looks good. Let's just rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] UI: Add regression tests for Dags list rows remounting on refresh [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #75005:
URL: https://github.com/apache/airflow/pull/75005#issuecomment-6300658843

   ### Backport successfully created: v3-4-test
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
           <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>✅</td>
           <td>v3-4-test</td>
           <td><a href="https://github.com/apache/airflow/pull/75252"><img src="https://img.shields.io/badge/PR-75252-blue" alt="PR Link"></a></td>
       </tr>
   </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] UI: Add regression tests for Dags list rows remounting on refresh [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.

bbovenzi merged PR #75005:
URL: https://github.com/apache/airflow/pull/75005


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org