[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10170: [Improvement][task sql] Improve creating function query

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #10170:
URL: https://github.com/apache/dolphinscheduler/pull/10170#discussion_r877940288


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -83,7 +83,7 @@ public class SqlTask extends AbstractTaskExecutor {
     /**
      * create function format
      */
-    private static final String CREATE_FUNCTION_FORMAT = "create temporary function {0} as ''{1}''";
+    private static final String CREATE_OR_REPLACE_FUNCTION_FORMAT = "create or replace temporary function {0} as ''{1}''";

Review Comment:
   I think this is unnessesary. It's temporary and won't last forever. If a method is reused, a non temporary method should be created.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org