You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/11 03:36:16 UTC
[GitHub] [incubator-inlong] yunqingmoswu opened a new pull request, #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
yunqingmoswu opened a new pull request, #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159
### Title Name: [INLONG-3828][Sort] Enhanced the node filter capabilities
Fixes #3828
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] thexiay commented on a diff in pull request #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
Posted by GitBox <gi...@apache.org>.
thexiay commented on code in PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159#discussion_r869975267
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/HiveLoadNode.java:
##########
@@ -88,7 +90,7 @@ public HiveLoadNode(@JsonProperty("id") String id,
@JsonProperty("hiveVersion") String hiveVersion,
@JsonProperty("hadoopConfDir") String hadoopConfDir,
@JsonProperty("parFields") List<FieldInfo> partitionFields) {
- super(id, name, fields, fieldRelationShips, filters, sinkParallelism, properties);
+ super(id, name, fields, fieldRelationShips, filters, filterStrategy, sinkParallelism, properties);
Review Comment:
recommand every load node,every extract node have a builder mode, so every time we add filed in 'LoadNode' or 'ExtractNode',We can avoid modifying the call site of the constructor call.
Better open an issue to follow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159#discussion_r869973148
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FilterFunctionUtils.java:
##########
@@ -91,6 +92,32 @@ public static List<FilterFunction> createFilterFunctions(FilterDefinition filter
return filterFunctions;
}
+ public static FilterStrategy parseFilterStrategy(TransformResponse transformResponse) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159#discussion_r870041996
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/HiveLoadNode.java:
##########
@@ -88,7 +90,7 @@ public HiveLoadNode(@JsonProperty("id") String id,
@JsonProperty("hiveVersion") String hiveVersion,
@JsonProperty("hadoopConfDir") String hadoopConfDir,
@JsonProperty("parFields") List<FieldInfo> partitionFields) {
- super(id, name, fields, fieldRelationShips, filters, sinkParallelism, properties);
+ super(id, name, fields, fieldRelationShips, filters, filterStrategy, sinkParallelism, properties);
Review Comment:
This is a good suggestion. After the later version is stable, this method can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap merged pull request #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4159: [INLONG-3828][Sort] Enhanced the node filter capabilities
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4159:
URL: https://github.com/apache/incubator-inlong/pull/4159#discussion_r869968271
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FilterFunctionUtils.java:
##########
@@ -91,6 +92,32 @@ public static List<FilterFunction> createFilterFunctions(FilterDefinition filter
return filterFunctions;
}
+ public static FilterStrategy parseFilterStrategy(TransformResponse transformResponse) {
Review Comment:
Please add java doc for static method, thanks.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FilterFunctionUtils.java:
##########
@@ -91,6 +92,32 @@ public static List<FilterFunction> createFilterFunctions(FilterDefinition filter
return filterFunctions;
}
+ public static FilterStrategy parseFilterStrategy(TransformResponse transformResponse) {
Review Comment:
Please add java doc for the static method, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org