[GitHub] [netbeans] BradWalker opened a new pull request #1722: [NETBEANS-3518] - fix bug in AbstractSummaryView.java

[GitBox <gi...@apache.org>]

BradWalker opened a new pull request #1722: [NETBEANS-3518] - fix bug in AbstractSummaryView.java
URL: https://github.com/apache/netbeans/pull/1722
 
 
   I was working on my usual code cleanup when I encountered a bug in the method AbstractSummaryView() in AbstractSummaryView.java..
   
   Notice the following code was not type-casting correctly..
   
   -                if (selection.length == 1) {
   -                    if (selection[0] instanceof ShowAllEventsItem) {
   -                        showRemainingFiles(((ShowAllEventsItem) selection[0]).getParent(), true);
   -                    } else if (selection[0] instanceof ShowLessEventsItem) {
   -                        showRemainingFiles(((ShowAllEventsItem) selection[0]).getParent(), false);
   -                    } else if (selection[0] instanceof MoreRevisionsItem) {
   
   Specifically, an instance of ShowLessEventsItem should be properly cast..
   
   +                        showRemainingFiles(((ShowLessEventsItem) selection.get(0)).getParent(), false);
   
   While I had the hood opened, I fixed a few other Java warnings..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists