You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/08/03 20:39:20 UTC
[jira] [Commented] (OOZIE-1173) Refactor: use ParamChecker
inXOozieClient
[ https://issues.apache.org/jira/browse/OOZIE-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406579#comment-15406579 ]
Hadoop QA commented on OOZIE-1173:
----------------------------------
Testing JIRA OOZIE-1173
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
. {color:red}-1{color} HEAD does not compile
. {color:red}-1{color} patch does not compile
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1792
. Tests failed: 7
. Tests errors: 2
. The patch failed the following testcases:
. testSomeMethods(org.apache.oozie.client.TestWorkflowXClient)
. testSubmitMR(org.apache.oozie.client.TestWorkflowXClient)
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3182/
> Refactor: use ParamChecker inXOozieClient
> -----------------------------------------
>
> Key: OOZIE-1173
> URL: https://issues.apache.org/jira/browse/OOZIE-1173
> Project: Oozie
> Issue Type: Task
> Components: client, core
> Reporter: jun aoki
> Assignee: abhishek bafna
> Priority: Trivial
> Labels: newbie
> Fix For: 4.3.0
>
> Attachments: OOZIE-1173-00.patch
>
>
> In [XOozieClient.java|http://svn.apache.org/viewvc/oozie/trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java?revision=1401367&view=markup], you can find a piece of code like this and should be replaced with ParamChecker.
> {code}
> if (conf == null) {
> throw new IllegalArgumentException("conf cannot be null");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)