You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Okumoto <ok...@ucsd.edu> on 2001/12/05 10:17:38 UTC
more non constants in struct initializers.
* subversion/libsvn_ra_local/commit_editor.c
Fixed non constants in struct initializers.
* subversion/subversion/tests/libsvn_repos/dir-delta-editor.c
Fixed non constants in struct initializers.
Index: subversion/subversion/libsvn_ra_local/commit_editor.c
===================================================================
--- subversion/subversion/libsvn_ra_local/.svn/text-base/commit_editor.c.svn-base Sun Dec 2 13:44:20 2001
+++ subversion/subversion/libsvn_ra_local/commit_editor.c Tue Dec 4 11:06:18 2001
@@ -490,7 +490,9 @@
{
struct file_baton *fb = file_baton;
struct edit_baton *eb = fb->parent->edit_baton;
- svn_string_t propvalue = { value->data, value->len };
+ svn_string_t propvalue;
+ propvalue.data = value->data;
+ propvalue.len = value->len;
/* This routine is a mindless wrapper. */
SVN_ERR (svn_fs_change_node_prop (eb->txn_root, fb->path->data,
@@ -507,7 +509,9 @@
{
struct dir_baton *db = dir_baton;
struct edit_baton *eb = db->edit_baton;
- svn_string_t propvalue = { value->data, value->len };
+ svn_string_t propvalue;
+ propvalue.data = value->data;
+ propvalue.len = value->len;
/* This routine is a mindless wrapper. */
SVN_ERR (svn_fs_change_node_prop (eb->txn_root, db->path->data,
Index: subversion/subversion/tests/libsvn_repos/dir-delta-editor.c
===================================================================
--- subversion/subversion/tests/libsvn_repos/.svn/text-base/dir-delta-editor.c.svn-base Sun Dec 2 13:36:11 2001
+++ subversion/subversion/tests/libsvn_repos/dir-delta-editor.c Tue Dec 4 11:44:30 2001
@@ -265,7 +265,9 @@
svn_stringbuf_t *name, svn_stringbuf_t *value)
{
struct file_baton *fb = (struct file_baton *) file_baton;
- svn_string_t propvalue = { value->data, value->len };
+ svn_string_t propvalue;
+ propvalue.data = value->data;
+ propvalue.len = value->len;
return svn_fs_change_node_prop (fb->dir_baton->edit_baton->txn_root,
fb->path->data, name->data, &propvalue,
@@ -278,7 +280,9 @@
svn_stringbuf_t *name, svn_stringbuf_t *value)
{
struct dir_baton *d = (struct dir_baton *) parent_baton;
- svn_string_t propvalue = { value->data, value->len };
+ svn_string_t propvalue;
+ propvalue.data = value->data;
+ propvalue.len = value->len;
return svn_fs_change_node_prop (d->edit_baton->txn_root,
d->path->data, name->data, &propvalue,
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: more non constants in struct initializers.
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Max and others,
To add to what Mike says below, I recommend
- read the HACKING file, it has examples of this
- also, run "svn log" and get many more examples :-)
-K
cmpilato@collab.net writes:
> I'm about to commit these patches, for which I certainly thank you.
> However, I must ask that in the future you include the symbol names of
> the function, global var, struct, prototype, etc. that was modified.
> 3 lines of context typically won't provide that info to a reviewer,
> and more importantly, if it isn't in the log message, 'svn log'
> because rather useless. I've added this information for these 2 (and
> your previous 3) patches, but have to ask that in the future you save
> me that step. Thanks, Max.
>
> Side note: Ben and I were wondering if you were using some sort of
> code profiling tool to find those memory leaks, or what?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: more non constants in struct initializers.
Posted by cm...@collab.net.
Max Okumoto <ok...@ucsd.edu> writes:
> * subversion/libsvn_ra_local/commit_editor.c
> Fixed non constants in struct initializers.
>
> * subversion/subversion/tests/libsvn_repos/dir-delta-editor.c
> Fixed non constants in struct initializers.
and:
> * subversion/subversion/libsvn_ra_dav/commit.c
> static const int variable needs init value even if it is zero.
--
I'm about to commit these patches, for which I certainly thank you.
However, I must ask that in the future you include the symbol names of
the function, global var, struct, prototype, etc. that was modified.
3 lines of context typically won't provide that info to a reviewer,
and more importantly, if it isn't in the log message, 'svn log'
because rather useless. I've added this information for these 2 (and
your previous 3) patches, but have to ask that in the future you save
me that step. Thanks, Max.
Side note: Ben and I were wondering if you were using some sort of
code profiling tool to find those memory leaks, or what?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org