You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/06/22 07:35:07 UTC
[GitHub] [hive] yulongz opened a new pull request, #3396: HIVE-26292 GroupByOperator initialization does not clean state
yulongz opened a new pull request, #3396:
URL: https://github.com/apache/hive/pull/3396
### What changes were proposed in this pull request?
Issue identified in [HIVE-14222](https://issues.apache.org/jira/browse/HIVE-14222).
GroupByOperator::initializeOp() does not reset currentKeys to null. This leads to incorrect result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yulongz commented on pull request #3396: HIVE-26292 GroupByOperator initialization does not clean state
Posted by GitBox <gi...@apache.org>.
yulongz commented on PR #3396:
URL: https://github.com/apache/hive/pull/3396#issuecomment-1170973173
> @yulongz I am confused here, in [current master](https://github.com/apache/hive/blob/bc35507757c23a6da612a2dc4b840105aed2515c/ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java#L83) I can already see `currentKeys` set to `null` in the very same place you proposed the change.
>
> Am I missing something? The patch indeed seems to have been merged long time ago by looking at the Jira ticket.
currentKeys in GroupByOperator , not only PTFOperator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on pull request #3396: HIVE-26292 GroupByOperator initialization does not clean state
Posted by GitBox <gi...@apache.org>.
asolimando commented on PR #3396:
URL: https://github.com/apache/hive/pull/3396#issuecomment-1170939816
@yulongz I am confused here, in [current master](https://github.com/apache/hive/blob/bc35507757c23a6da612a2dc4b840105aed2515c/ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java#L83) I can already see `currentKeys` set to `null` in the very same place you proposed the change.
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3396: HIVE-26292 GroupByOperator initialization does not clean state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3396:
URL: https://github.com/apache/hive/pull/3396#issuecomment-1231004668
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3396: HIVE-26292 GroupByOperator initialization does not clean state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3396: HIVE-26292 GroupByOperator initialization does not clean state
URL: https://github.com/apache/hive/pull/3396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org