You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-dev@hadoop.apache.org by "Mehran Hassani (JIRA)" <ji...@apache.org> on 2017/11/13 20:59:00 UTC

[jira] [Created] (YARN-7485) Add LOG.isDebugEnabled() guard for LOG.debug("")

Mehran Hassani created YARN-7485:
------------------------------------

             Summary: Add LOG.isDebugEnabled() guard for LOG.debug("")
                 Key: YARN-7485
                 URL: https://issues.apache.org/jira/browse/YARN-7485
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Mehran Hassani
            Priority: Minor


I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. In these files, there are debug level logging statements containing multiple string concatenation without the if statement before them: 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/HadoopYarnProtoRPC.java, LOG.debug("Creating a HadoopYarnProtoRpc server for protocol " + protocol +" with " + numHandlers + " handlers");, 61
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java, LOG.debug("Received node update event:" + type + " for node:" + node+ " with state:" + nodeState);, 985

Would you be interested in adding the if before these logging statements?

There are 14 more cases that I can mention if needed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org