[jira] [Work logged] (GOBBLIN-1625) Gobblin hive table path checks needs to be more robust

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1625?focusedWorklogId=744493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744493 ]

ASF GitHub Bot logged work on GOBBLIN-1625:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/22 23:50
            Start Date: 18/Mar/22 23:50
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request #3482:
URL: https://github.com/apache/gobblin/pull/3482


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1625
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   There are edge cases where hive tables are rejected due to the mismatch check not being robust enough. For example:
   1. If the user specified path and the existing hive table path are exact matches, we should always return that they are equivalent
   
   2. If the existing hive table path does not exist on the filesystem, we need to recursively check the parents to see if the fs.uri and folder directories are equivalent
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Added test cases for each observed scenario
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 744493)
    Remaining Estimate: 0h
            Time Spent: 10m

> Gobblin hive table path checks needs to be more robust
> ------------------------------------------------------
>
>                 Key: GOBBLIN-1625
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1625
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are edge cases where hive tables are rejected due to the mismatch check not being robust enough. For example:
> 1. If the user specified path and the existing hive table path are exact matches, we should always return that they are equivalent
> 2. If the existing hive table path does not exist on the filesystem, we need to recursively check the parents to see if the fs.uri and folder directories are equivalent



--
This message was sent by Atlassian Jira
(v8.20.1#820001)