[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30263: [SPARK-33358][SQL] Return code when command process failed

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #30263:
URL: https://github.com/apache/spark/pull/30263#discussion_r523839759



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -571,4 +571,13 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
     // the date formatter for `java.sql.LocalDate` must output negative years with sign.
     runCliWithin(1.minute)("SELECT MAKE_DATE(-44, 3, 15);" -> "-0044-03-15")
   }
+
+  test("SPARK-33358 CLI should break when have command failed") {

Review comment:
       This test case seems to succeed without your patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org