You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2014/01/08 19:52:17 UTC

[jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

You can merge this Pull Request by running:

  git pull https://github.com/abayer/jclouds-labs-google jclouds-416

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/19

-- Commit Summary --

  * JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky.

-- File Changes --

    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/options/GoogleComputeEngineTemplateOptions.java (26)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/19.patch
https://github.com/jclouds/jclouds-labs-google/pull/19.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #42](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/42/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31875853

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Phillips <no...@github.com>.
Another [compilation failure](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/41/console). Was this also an expected one?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31871998

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Bayer <no...@github.com>.
Yup, new push incoming.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31875321

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Phillips <no...@github.com>.
>      */
>     public Optional<String> getNetworkName() {
> -      return networkName;
> +      return fromNullable(Iterables.getFirst(getNetworks(), null));

I guess this is the "bit janky" bit? I see what you mean. The user can get at _all_ networks too, though? In that case, add a `@see` Javadoc to the relevant method? And/or deprecate this one?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19/files#r8734721

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #605](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/605/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31865421

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Phillips <no...@github.com>.
> @@ -337,9 +354,10 @@ public GoogleComputeEngineTemplateOptions blockOnComplete(boolean blockOnComplet
>     /**
>      * @return the name of an existing network the instances will be attached to, the network is assumed to belong to
>      *         user's project. If no network URI network name are provided a new network will be created for the project.
> +    *         Note that this is now pulling from the first element in the networks field from TemplateOptions.

Make this `<b>bold</b>`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19/files#r8734727

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Bayer <no...@github.com>.
Failure is because I was dumb and pushed this before the jclouds build with the JCLOUDS-416 change had run. Whoops. Will wait to re-push.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31866081

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Bayer <no...@github.com>.
>      */
>     public Optional<String> getNetworkName() {
> -      return networkName;
> +      return fromNullable(Iterables.getFirst(getNetworks(), null));

They *could* get at all networks, but GCE only allows one, so anything past the first is going to be ignored no matter what. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19/files#r8734814

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Bayer <no...@github.com>.
> @@ -337,9 +354,10 @@ public GoogleComputeEngineTemplateOptions blockOnComplete(boolean blockOnComplet
>     /**
>      * @return the name of an existing network the instances will be attached to, the network is assumed to belong to
>      *         user's project. If no network URI network name are provided a new network will be created for the project.
> +    *         Note that this is now pulling from the first element in the networks field from TemplateOptions.

Okiedokie.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19/files#r8734777

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by Andrew Phillips <no...@github.com>.
Needs to be backported to 1.7.x, I guess?

https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-1.7.x-branch/61/console

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-33255351

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #41](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/41/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31867178