You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Benjamin-Philip (via GitHub)" <gi...@apache.org> on 2026/06/30 07:08:42 UTC
[PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Benjamin-Philip opened a new pull request, #69:
URL: https://github.com/apache/arrow-erlang/pull/69
## What issue does this PR close?
Doesn't close a tracked issue.
Dependabot updates do not respect the ASF allowlist. Thus, some dependabot PRs
can silently break workflows as seen in #63.
## What's changed
A workflow to perform to ASF allowlist checks on changes to `.github` has been
added. Any breakages introduced by dependabot updates (or any other changes)
will be highlighted.
Copied verbatim from https://github.com/apache/arrow-adbc/blob/main/.github/workflows/asf-allowlist-check.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69#issuecomment-4849140483
> Could you open an issue for this?
> See also: https://github.com/apache/arrow-erlang/blob/main/CONTRIBUTING.md#minor-fixes
I've opened #70.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69#discussion_r3497266104
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# See https://github.com/apache/iceberg/blob/main/.github/workflows/asf-allowlist-check.yml
+name: "GitHub Actions Checks"
+
+on:
+ pull_request:
+ paths:
+ - ".github/**"
+ push:
+ branches:
+ - main
Review Comment:
Can we remove this?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69#discussion_r3496829035
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# See https://github.com/apache/iceberg/blob/main/.github/workflows/asf-allowlist-check.yml
+name: "GitHub Actions Checks"
+
+on:
+ pull_request:
+ paths:
+ - ".github/**"
+ push:
+ branches:
+ - main
+ paths:
+ - ".github/**"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ gha:
+ name: "Analyze Actions"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+ with:
+ persist-credentials: false
+
+ # Check that actions are pinned and on the ASF allowlist.
+ # Intentionally unpinned to always use the latest allowlist from the ASF.
+ - uses: apache/infrastructure-actions/allowlist-check@main # zizmor: ignore[unpinned-uses]
+
+ # Analyze workflows with Zizmor
+ - name: Run zizmor 🌈
+ uses: zizmorcore/zizmor-action@5f14fd08f7cf1cb1609c1e344975f152c7ee938d # v0.5.6
+ with:
+ advanced-security: false
Review Comment:
`steps:` is not indented correctly: the list items (`- uses:` / `- name:`) are aligned with `steps:` instead of being nested under it. This makes the workflow YAML invalid and will prevent the workflow from running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69#discussion_r3496856747
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# See https://github.com/apache/iceberg/blob/main/.github/workflows/asf-allowlist-check.yml
+name: "GitHub Actions Checks"
+
+on:
+ pull_request:
+ paths:
+ - ".github/**"
+ push:
+ branches:
+ - main
+ paths:
+ - ".github/**"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
Review Comment:
`concurrency.group` falls back to `github.sha` for `push` events, which makes each push run use a unique concurrency group. With `cancel-in-progress: true`, this means pushes to `main` will not cancel prior in-progress runs (the concurrency setting becomes effectively a no-op for pushes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Perform ASF allowlist checks on CI changes [arrow-erlang]
Posted by "Benjamin-Philip (via GitHub)" <gi...@apache.org>.
Benjamin-Philip commented on PR #69:
URL: https://github.com/apache/arrow-erlang/pull/69#issuecomment-4840901499
I'm thinking we can merge this PR (since the workflow itself is working) and fix the linting errors in later PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org