[GitHub] [incubator-kyuubi] turboFei edited a comment on pull request #2122: [KYUUBI #2102] Support to retry the internal thrift RPC call and fast fail on transport closed or instability

[GitBox <gi...@apache.org>]

turboFei edited a comment on pull request #2122:
URL: https://github.com/apache/incubator-kyuubi/pull/2122#issuecomment-1066229584


   For method `withLockAcquired`:
   ```
     /**
      * Lock every rpc call to send them sequentially
      */
     private def withLockAcquired[T](block: => T): T = {
       try {
         lock.lock()
         if (!protocol.getTransport.isOpen) {
           throw KyuubiSQLException.connectionDoesNotExist()
         }
         block
       } finally lock.unlock()
     }
   ```
   It has checked whether the underlying socket is connected, so I wonder whether this pr will take affect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org