You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2012/06/18 07:59:01 UTC
Review Request: HIVE-3100: Integrate SQLLine command line editor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Description
-------
The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
Diffs
-----
LICENSE 05085da
NOTICE 871fdde
bin/ext/sqlline.sh PRE-CREATION
bin/ext/util/execHiveCmd.sh 167cc40
cli/ivy.xml ab949b1
ivy.xml e83437e
ivy/ivysettings.xml fb6f4b8
ivy/libraries.properties 8461da1
Diff: https://reviews.apache.org/r/5381/diff/
Testing
-------
Thanks,
Prasad Mujumdar
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Carl Steinbach <ca...@cloudera.com>.
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > LICENSE, line 421
> > <https://reviews.apache.org/r/5381/diff/2/?file=111880#file111880line421>
> >
> > Please replace with the license text from CVS.
>
> Prasad Mujumdar wrote:
> I am still not fully convinced that copying the CVS license is the right way. Here are following things to consider -
> 1) The source distributions (even 1.0.2) still includes the old license file which contains GNU license.
> 2) In fact this license change from GNU to BSD was done in 1.0.2 release, so I am not sure if that makes 1.0 a GNU license release. Just to be safe, I put a added a workaround in the ivy script to use 1.0.2. Though on a related note, I am not sure if its possible to change license from GNU to non-GNU on the same codebase ...
> 3) The binary distributions are not including the license text in CVS repository in any format, also its not there on the download site. Hence I don't know if this qualifies to be a license under which Hive is using/redistributing sqlline.
>
> 1) The source distributions (even 1.0.2) still includes the old license file which contains GNU license.
See the discussion here: http://old.nabble.com/Bug-491805%3A-RFS%3A-sqlline-td18718027.html
Specifically:
I've contacted upstream (Marc Prud'hommeaux) about this issue, and he reply to
me :
"
SQLLine was once GPL, but it was changed to be BSD a few years back.
Any references to the GPL are vestigial. Hopefully the license
declaration at http://sqlline.sourceforge.net/#license is sufficiently
authoritative in this regard.
"
> Though on a related note, I am not sure if its possible to change license from GNU to non-GNU on the same codebase
The original copyright holder (in this case Mr. Prud'hommeaux) can do whatever he wants. See http://stackoverflow.com/questions/1077668/can-i-change-my-open-source-license-from-licensea-to-licenseb
> The binary distributions are not including the license text in CVS repository in any format, also its not there on the download site. Hence I don't know if this qualifies to be a license under which Hive is using/redistributing sqlline.
Ok, then let's copy what the Ubuntu maintainers have done: https://launchpad.net/ubuntu/jaunty/+source/sqlline/+copyright
---------------------------------------
For the SQLLine library:
Copyright (c) 2002, 2003, 2004, 2005 Marc Prud'hommeaux
From: http://sqlline.sourceforge.net/#license
"SQLLine is distributed under the BSD License, meaning that you are free to redistribute, modify, or sell the software with almost no restrictions."
Statement from Marc Prud'hommeaux regarding inconsistent licenses in some SQLLine source files:
> SQLLine was once GPL, but it was changed to be BSD a few years back.
> Any references to the GPL are vestigial. Hopefully the license
> declaration at http://sqlline.sourceforge.net/#license is sufficiently
> authoritative in this regard.
----------------------------------------
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8346
-----------------------------------------------------------
On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:19 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> cli/ivy.xml ab949b1
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > I think it's important to get local mode working and also put a Java wrapper in place before committing this.
ok. I will make changes and update the patch.
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > LICENSE, line 421
> > <https://reviews.apache.org/r/5381/diff/2/?file=111880#file111880line421>
> >
> > Please replace with the license text from CVS.
I am still not fully convinced that copying the CVS license is the right way. Here are following things to consider -
1) The source distributions (even 1.0.2) still includes the old license file which contains GNU license.
2) In fact this license change from GNU to BSD was done in 1.0.2 release, so I am not sure if that makes 1.0 a GNU license release. Just to be safe, I put a added a workaround in the ivy script to use 1.0.2. Though on a related note, I am not sure if its possible to change license from GNU to non-GNU on the same codebase ...
3) The binary distributions are not including the license text in CVS repository in any format, also its not there on the download site. Hence I don't know if this qualifies to be a license under which Hive is using/redistributing sqlline.
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > bin/ext/sqlline.sh, line 16
> > <https://reviews.apache.org/r/5381/diff/2/?file=111882#file111882line16>
> >
> > Missing "[db]". Also, this is what sqlline_help() should print.
Done
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > bin/ext/sqlline.sh, line 17
> > <https://reviews.apache.org/r/5381/diff/2/?file=111882#file111882line17>
> >
> > Would you mind changing the name to "beeline"? That was the name John used in his original patch and I think it's kind of cute.
Done
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > bin/ext/sqlline.sh, line 27
> > <https://reviews.apache.org/r/5381/diff/2/?file=111882#file111882line27>
> >
> > Please use getopts (http://rsalveti.wordpress.com/2007/04/03/bash-parsing-arguments-with-getopts/) or delegate command line option handling to a Java wrapper. The latter option is preferred since it's more portable and is arguably less fragile.
yes, will pass it to the java warpper and include in the updated patch.
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > bin/ext/sqlline.sh, line 32
> > <https://reviews.apache.org/r/5381/diff/2/?file=111882#file111882line32>
> >
> > Where is execSQLLine defined?
removed
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > bin/ext/sqlline.sh, line 37
> > <https://reviews.apache.org/r/5381/diff/2/?file=111882#file111882line37>
> >
> > The help options that get dumped here are inaccessible from the command line.
changed to print the hive options
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote:
> > cli/ivy.xml, line 40
> > <https://reviews.apache.org/r/5381/diff/2/?file=111883#file111883line40>
> >
> > I think it probably makes more sense for this to be a dependency on the hive-jdbc module. Otherwise we also need to add a hive-jdbc dependency to hive-cli which is something I would rather avoid.
> >
> > On a related note, the BeeLine wrapper and command processor also belongs in the hive-jdbc module.
hmm .. ok. will do that.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8346
-----------------------------------------------------------
On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:19 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> cli/ivy.xml ab949b1
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8346
-----------------------------------------------------------
I think it's important to get local mode working and also put a Java wrapper in place before committing this.
LICENSE
<https://reviews.apache.org/r/5381/#comment17992>
Please replace with the license text from CVS.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17994>
Missing "[db]". Also, this is what sqlline_help() should print.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17999>
Would you mind changing the name to "beeline"? That was the name John used in his original patch and I think it's kind of cute.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17997>
Please use getopts (http://rsalveti.wordpress.com/2007/04/03/bash-parsing-arguments-with-getopts/) or delegate command line option handling to a Java wrapper. The latter option is preferred since it's more portable and is arguably less fragile.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17995>
Where is execSQLLine defined?
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17996>
The help options that get dumped here are inaccessible from the command line.
cli/ivy.xml
<https://reviews.apache.org/r/5381/#comment18000>
I think it probably makes more sense for this to be a dependency on the hive-jdbc module. Otherwise we also need to add a hive-jdbc dependency to hive-cli which is something I would rather avoid.
On a related note, the BeeLine wrapper and command processor also belongs in the hive-jdbc module.
- Carl Steinbach
On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:19 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> cli/ivy.xml ab949b1
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8349
-----------------------------------------------------------
One more request: Can you add an Eclipse launch configuration similar to HiveCLI.launchtemplate that runs the SQLLine CLI in local mode? Thanks!
- Carl Steinbach
On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:19 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> cli/ivy.xml ab949b1
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/
-----------------------------------------------------------
(Updated June 18, 2012, 6:19 p.m.)
Review request for hive and Carl Steinbach.
Changes
-------
Changes per review comments
Description
-------
The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
Diffs (updated)
-----
LICENSE 05085da
NOTICE 871fdde
bin/ext/sqlline.sh PRE-CREATION
cli/ivy.xml ab949b1
ivy/ivysettings.xml fb6f4b8
ivy/libraries.properties 8461da1
Diff: https://reviews.apache.org/r/5381/diff/
Testing
-------
Thanks,
Prasad Mujumdar
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8321
-----------------------------------------------------------
LICENSE
<https://reviews.apache.org/r/5381/#comment17928>
This is the BSD license template, not the actual license. Looks like the updated BSD license is available in the SQLLine CVS repository here: http://sqlline.cvs.sourceforge.net/viewvc/sqlline/LICENSE?view=markup
NOTICE
<https://reviews.apache.org/r/5381/#comment17929>
Please change this to:
This product includes/uses SQLLine (http://sqlline.sourceforge.net),
Copyright (c) 2002, 2003, 2004, 2005 Marc Prud'hommeaux <mw...@cornell.edu>.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17933>
If no hostname is specified this script should probably run the driver in embedded mode (e.g. with a connect string equal to "jdbc:hive://", or see TestJdbcDriver for another example).
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17932>
The default HiveServer listen port is 10000.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17934>
"-n foo -p bar"?
Is it possible to modify this in order to make it possible for the user to pass options to SQLLine from the command line (e.g. --showWarnings, --outputformat, etc)?
Why is "--silent" hardcoded here (and is this --silent=true or --silent=false)?
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17943>
I see this error message three times when I start the sqlline CLI: "Error: Method not supported (state=,code=0)"
Any idea what's causing that?
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17936>
This prints out the SQLLine options, but I don't think those options are actually accessible if you start it using this script.
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17944>
I don't think there's any benefit to putting this function here. Please move this back to sqlline.sh
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17945>
We removed support for Hadoop versions < 20 several versions ago. Please remove this comment.
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17946>
I dumped the values of these variables and they don't look right:
CLASS = "-u"
HIVE_OPTS = ""
@ = "jdbc:hive://localhost:10000/default -n foo -p bar -d org.apache.hadoop.hive.jdbc.HiveDriver --silent"
Including $HIVE_OPTS isn't appropriate in this circumstance. That environment variable is supposed to contain a list of "-hiveconf xx" settings, and the logic for processing these options is located in o.a.h.hive.cli.OptionsProcessor, which doesn't get invoked when you start SQLLine like this.
One option for fixing this is to create a BeeLine java wrapper around SQLLine, and invoke SQLLine's main() method from BeeLine.main() after processing the -hiveconf options.
ivy.xml
<https://reviews.apache.org/r/5381/#comment17930>
Why is this listed as a dependency both here and in cli/ivy.xml? I think this instance can be removed.
ivy/libraries.properties
<https://reviews.apache.org/r/5381/#comment17931>
We should probably depend on version 1.0.2 assuming it works (http://sourceforge.net/projects/sqlline/files/sqlline/1.0.2/).
- Carl Steinbach
On June 18, 2012, 5:59 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 5:59 a.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> bin/ext/util/execHiveCmd.sh 167cc40
> cli/ivy.xml ab949b1
> ivy.xml e83437e
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Carl Steinbach <ca...@cloudera.com>.
> On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote:
> > LICENSE, line 421
> > <https://reviews.apache.org/r/5381/diff/1/?file=111540#file111540line421>
> >
> > This is the text posted on the SQLLine site site from where the hive build is downloading the jar. Since we are not using the source jar or making source changes, do we need to look at any other license terms than one listed for distribution ?
> >
The problem is that this is the BSD license template. Until the fields are filled in it doesn't carry any weight as a legal document. I don't think it's a acceptable for us to fill those fields in on our own, and the only version of the license I could find is the one in version control. I think including that version here is our best bet.
> On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote:
> > bin/ext/sqlline.sh, line 23
> > <https://reviews.apache.org/r/5381/diff/1/?file=111542#file111542line23>
> >
> > hmm .. how about make that under a specific option like '--local or -l'. If an embedded mode is needed, then its better be invoked explicitly than overloading the host (or absence of it).
> > I will log a separate ticket or subtask to address that if you agree.
I think local mode should be the default in order to make the JDBC CLI an easy drop-in replacement for the current CLI.
> On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote:
> > ivy/libraries.properties, line 52
> > <https://reviews.apache.org/r/5381/diff/1/?file=111547#file111547line52>
> >
> > The directory and file names for version 1.0.2 are following different conventions that makes it hard to access it in ivy.
> > I will followup with SQLLine community to address it if possible.
Ok, sounds good.
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8331
-----------------------------------------------------------
On June 18, 2012, 6:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 6:19 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> cli/ivy.xml ab949b1
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100: Integrate SQLLine command line editor
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5381/#review8331
-----------------------------------------------------------
LICENSE
<https://reviews.apache.org/r/5381/#comment17949>
This is the text posted on the SQLLine site site from where the hive build is downloading the jar. Since we are not using the source jar or making source changes, do we need to look at any other license terms than one listed for distribution ?
NOTICE
<https://reviews.apache.org/r/5381/#comment17950>
Done
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17952>
hmm .. how about make that under a specific option like '--local or -l'. If an embedded mode is needed, then its better be invoked explicitly than overloading the host (or absence of it).
I will log a separate ticket or subtask to address that if you agree.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17953>
was testing this earlier with a dummy HS2 server with default port 10001. sorry about that.
Fixed
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17957>
removed the user/passwd arguments. Its not actually mandatory for sqlline tool invocation (if the URL is specified) and hive server currently doesn't require it.
The 'silent' options suppresses version information that sqlline prints, From what I understand the JDBC driver doesn't provide very meaningful version details. It can also clutter the output and create problem for test output comparisons due to version information.
For command line invocation, silent is default false and --silent makes it true.
Changed that to --silent=true for better readability.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17959>
yes, the SQLLine invokes JDBC methods to check autoCommit, isolation and extraNameCharacters which are not supported by hive.
bin/ext/sqlline.sh
<https://reviews.apache.org/r/5381/#comment17961>
The options can be changed within the editor after it starts.
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17963>
Done
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17964>
Done
bin/ext/util/execHiveCmd.sh
<https://reviews.apache.org/r/5381/#comment17968>
ok.
I was planing to add a java wrapper, primarily for the commandline or batch execution of HQL. The SQLLine currently requires a script that's written using its own command syntax and doesn't support equivalent of '-e HQL' or '-f <FILE.QL>'
I will log a ticket to create a wrapper that address all these three issues.
ivy.xml
<https://reviews.apache.org/r/5381/#comment17951>
right. Didn't remote this in the previous patch.
Done
ivy/libraries.properties
<https://reviews.apache.org/r/5381/#comment17972>
The directory and file names for version 1.0.2 are following different conventions that makes it hard to access it in ivy.
I will followup with SQLLine community to address it if possible.
- Prasad Mujumdar
On June 18, 2012, 5:59 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5381/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 5:59 a.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> The patch is to include command line SQL editor SQLLine into Hive distribution. The tool can be invoked using 'hive --service sqlline <host> [port]'. It requires the HiveServer running on the given host/port.
>
> The ivy dependencies are updated to include sqlline. The hive scripts are updated to executing SQLLine with the required connection URL and other command line options. The LICENSE and NOTICE files are updated to include SQLLine information.
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/sqlline.sh PRE-CREATION
> bin/ext/util/execHiveCmd.sh 167cc40
> cli/ivy.xml ab949b1
> ivy.xml e83437e
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
>
> Diff: https://reviews.apache.org/r/5381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>