You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@polaris.apache.org by Christopher Lambert <XN...@gmx.de.INVALID> on 2025/09/29 08:38:53 UTC

[DISCUSS] Use PrincipalEntity in PolarisMetaStoreManager.createPrincipal

Hello everyone,

I have a PR in review that reworks 
"PolarisMetaStoreManager.createPrincipal" from operating on 
"PolarisBaseEntity" to operating on "PrincipalEntity":
https://github.com/apache/polaris/pull/2518

This provides more type-safety and property validation and thus 
simplifies both method call sites and method implementations.

I was asked to start a discussion for the PR on the mailing list for 
awareness or in case there are any strong objections to this change.

Thank you

Christopher

Re: [DISCUSS] Use PrincipalEntity in PolarisMetaStoreManager.createPrincipal

Posted by Dmitri Bourlatchkov <di...@apache.org>.

Thanks for starting this discussion, Christopher!

I approved the PR in GH. I think it is a valuable refactoring and it aligns
with our code evolution approach [1]

[1] https://polaris.apache.org/releases/1.1.0/evolution/

Cheers,
Dmitri.

On Mon, Sep 29, 2025 at 4:39 AM Christopher Lambert <XN...@gmx.de.invalid>
wrote:

> Hello everyone,
>
> I have a PR in review that reworks
> "PolarisMetaStoreManager.createPrincipal" from operating on
> "PolarisBaseEntity" to operating on "PrincipalEntity":
> https://github.com/apache/polaris/pull/2518
>
> This provides more type-safety and property validation and thus
> simplifies both method call sites and method implementations.
>
> I was asked to start a discussion for the PR on the mailing list for
> awareness or in case there are any strong objections to this change.
>
> Thank you
>
> Christopher
>
>