[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #8706: [Feature][Login] Add SSO login by Casdoor

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r1030071953


##########
pom.xml:
##########
@@ -86,6 +86,7 @@
         <exec-maven-plugin.version>3.0.0</exec-maven-plugin.version>
         <owasp-dependency-check-maven.version>7.1.2</owasp-dependency-check-maven.version>
         <lombok.version>1.18.20</lombok.version>
+        <casdoor.version>1.6.0</casdoor.version>

Review Comment:
   Should add this to `dolphinscheduler-bom` module.



##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -90,7 +90,7 @@ registry:
 
 security:
   authentication:
-    # Authentication types (supported types: PASSWORD,LDAP)
+    # Authentication types (supported types: PASSWORD,LDAP,CASDOOR_SSO)

Review Comment:
   The `dolphinscheduler-api`  application.yaml should update too.



##########
dolphinscheduler-dist/release-docs/licenses/LICENSE-lombok.txt:
##########
@@ -0,0 +1,104 @@
+Copyright (C) 2009-2021 The Project Lombok Authors.

Review Comment:
   I found the scope of `lombok` is `provided`, Should we add lombok license file? cc @kezhenxu94 @ruanwenjun 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org