[jira] Resolved: (CXF-2552) CXF should use Spring's BeanFactory.isSingleton(name) instead of BeanDefinition.isSingleton() because any such checks break when using bean definition inheritance or bean definition post-processing

["Daniel Kulp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CXF-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2552.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.6
                   2.1.9

> CXF should use Spring's BeanFactory.isSingleton(name) instead of BeanDefinition.isSingleton() because any such checks break when using bean definition inheritance or bean definition post-processing
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-2552
>                 URL: https://issues.apache.org/jira/browse/CXF-2552
>             Project: CXF
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.2.6, 2.3
>            Reporter: Gyorgy Orban
>            Assignee: Daniel Kulp
>             Fix For: 2.1.9, 2.2.6
>
>
> Also, the default value of BeanDefinition.isSingleton() is likely to change to false in Spring 3, which breaks present CXF logic (in fact, they have already changed it to false in Spring 3 RC2, but backed off the change to our request). 
> Please see the reply from Juergen Hoeller of SpringSource:
> >2009/11/19 Juergen Hoeller <Ju...@springsource.com>
> >This is a half-intended effect, actually: We do not set a default scope name anymore in order to be able to inherit the scope name from a parent bean >definition... The default scope is still singleton but it won't be actually set before activating the bean definition in the factory now. That had the somewhat >unintended effect of BeanDefinition.isSingleton() now returning false by default.
>  
> >So as of tonight, BeanDefinitions return isSingleton()=true by default again. The scope name is still not set but BeanDefinitions assume that they are >singleton by default again now. Please give the next snapshot a try with CXF and let us know whether it works...
>  
> >Note that the proper way to check the singleton status of a bean is BeanFactory.isSingleton(name) on the activated factory. Any checks on the raw >BeanDefinition itself break when using bean definition inheritance or bean definition post-processing. From that perspective, CXF should get rid of those >calls eventually... I'm deprecating those BeanDefiniton methods now to make that clear.
>  
> >Juergen

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.