You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/02/28 17:17:17 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #6946: Python: Fix timezone concat issue

Fokko commented on code in PR #6946:
URL: https://github.com/apache/iceberg/pull/6946#discussion_r1120462738


##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -391,7 +391,7 @@ def visit_timestamp(self, _: TimestampType) -> pa.DataType:
         return pa.timestamp(unit="us")
 
     def visit_timestampz(self, _: TimestamptzType) -> pa.DataType:
-        return pa.timestamp(unit="us", tz="+00:00")
+        return pa.timestamp(unit="us", tz="UTC")

Review Comment:
   Technically yes. https://github.com/apache/iceberg/issues/6945 has a deeper explanation for this. It is because the test data is written using a docker container that is using UTC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org