You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/06/16 18:55:11 UTC
[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/844
[FLINK-2214] [ml] Fixes prediction join operation and empirical risk join operation of ALS by giving join hint
Fixes prediction join operation and empirical risk join operation of ALS by giving join hint. The user factors and item factors matrices are now used as the build side of the hash join.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixALS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/844.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #844
----
commit c7b3adce266d7d9df0fb5ce37bc096fa2825fdaf
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-06-16T16:53:12Z
[FLINK-2214] [ml] Fixes prediction join operation and empirical risk join operation of ALS by giving join hint
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/844#issuecomment-114045049
The build side hinted here is also the constant (loop invariant) side, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/844#issuecomment-112822761
If there are no objections, I'll merge this PR in the evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/844#issuecomment-114403301
It's not a problem with the joins of the loop but instead with the single join of the empirical risk and prediction calculation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---