You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/06 21:32:00 UTC
[GitHub] [netbeans] jgneff opened a new pull request, #4933: Import local schema to avoid DNS lookup in build
jgneff opened a new pull request, #4933:
URL: https://github.com/apache/netbeans/pull/4933
This pull request changes two files to fix [apache/netbeans#4920](https://github.com/apache/netbeans/issues/4920).
1. It modifies `jakartaee_9.xsd` to import the "xml:" namespace from a local copy of `xml.xsd` instead of importing it remotely from `http://www.w3.org/2001/xml.xsd`.
2. It replaces the local `xml.xsd` file with the latest [version dated 2009-01](https://www.w3.org/2009/01/xml.xsd) instead of the previous copy which seems to have been derived from the earliest [version dated 2001-03](https://www.w3.org/2001/03/xml.xsd).
Furthermore, I made the following changes to the `xml.xsd` file from the W3C:
* I removed the XML stylesheet because it causes a same-origin policy error in Firefox when viewing the file locally: "Error loading stylesheet: An unknown error has occurred (805303f4)."
* I added the current [W3C Software and Document Notice and License](https://www.w3.org/Consortium/Legal/copyright-software) as a comment formatted with an 80-character line length.
* I removed all trailing whitespace in the file.
How can I test this fix locally? I tried the following two test targets. The first one worked, but the second one failed.
```console
$ ant -quiet -Dmetabuild.branch=release160 -Dcluster.config=release commit-validation
$ ant -quiet -Dmetabuild.branch=release160 -Dcluster.config=release test-basic
```
Let's add this to NetBeans 16 only if someone far more knowledgeable than I am about JavaEE and Jakarta can review and approve it. Otherwise, I have a workaround and can wait for the fix in NetBeans 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4933: Import local schema to avoid DNS lookup in build
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4933:
URL: https://github.com/apache/netbeans/pull/4933#issuecomment-1305348583
Requested reviews and we'll see if we have a 16-rc4. Can you move the commit (rebase onto) delivery, so that it's possible to merge there if necessary. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jgneff commented on pull request #4933: Import local schema to avoid DNS lookup in build
Posted by GitBox <gi...@apache.org>.
jgneff commented on PR #4933:
URL: https://github.com/apache/netbeans/pull/4933#issuecomment-1305799599
> Actually, changed base is clean. Thanks!
Thanks, Neil. My local pull-request branch is also based off the *delivery* branch. I didn't notice that GitHub used the *master* branch as a base by default. Good to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4933: Import local schema to avoid DNS lookup in build
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4933:
URL: https://github.com/apache/netbeans/pull/4933#issuecomment-1305674262
will we remember to do the same for the next xsd which is added? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4933: Import local schema to avoid DNS lookup in build
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4933:
URL: https://github.com/apache/netbeans/pull/4933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists