You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/06/24 12:46:25 UTC
[GitHub] [fineract] rrpawar96 opened a new pull request, #2380: FINERACT-1430:ClientSocialStatus
rrpawar96 opened a new pull request, #2380:
URL: https://github.com/apache/fineract/pull/2380
JIRA: https://issues.apache.org/jira/browse/FINERACT-1430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] rrpawar96 closed pull request #2380: FINERACT-1430:ClientSocialStatus
Posted by GitBox <gi...@apache.org>.
rrpawar96 closed pull request #2380: FINERACT-1430:ClientSocialStatus
URL: https://github.com/apache/fineract/pull/2380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2380: FINERACT-1430:ClientSocialStatus
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2380:
URL: https://github.com/apache/fineract/pull/2380#discussion_r938661926
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -459,13 +466,14 @@ public CommandProcessingResult updateClient(final Long clientId, final JsonComma
clientForUpdate.updateSavingsProduct(savingsProductId);
}
- if (changes.containsKey(ClientApiConstants.genderIdParamName)) {
Review Comment:
@rrpawar96 Why did you override the update logic of gender?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2380: FINERACT-1430:ClientSocialStatus
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2380:
URL: https://github.com/apache/fineract/pull/2380#issuecomment-1193427277
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org