You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/03/24 11:20:13 UTC

[GitHub] [camel-k] gansheer opened a new pull request, #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

gansheer opened a new pull request, #4162:
URL: https://github.com/apache/camel-k/pull/4162

   Fixes #4160 
   
   ## Motivation
   
   When using `kamel uninstall` command the CamelCatalogs CR are not removed from the cluster. When an operator with the same Runtime is installed, it is already considered as Ready so the builder image container is not builded again with the code from the operator.
   
   ## Description
   
   Remove all the CamelCatalogs in the namespace of the operator on `kamel uninstall call` and add a `skip-camel-catalogs` flag.
   
   
   **Release Note**
   ```release-note
   Fix(cli): Remove CamelCatalogs CR on kamel uninstall
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] gansheer commented on a diff in pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#discussion_r1147496760


##########
pkg/util/defaults/defaults.go:
##########
@@ -26,7 +26,7 @@ const (
 	Version = "2.0.0-SNAPSHOT"
 
 	// DefaultRuntimeVersion --
-	DefaultRuntimeVersion = "1.18.0-SNAPSHOT"
+	DefaultRuntimeVersion = "3.20.1-SNAPSHOT"

Review Comment:
   This was changed automatically, should I revert this change ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#discussion_r1147457200


##########
pkg/cmd/uninstall.go:
##########
@@ -62,6 +63,7 @@ func newCmdUninstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *uninstall
 	cmd.Flags().Bool("skip-config-maps", false, "Do not uninstall the Camel K Config Maps in the current namespace")
 	cmd.Flags().Bool("skip-registry-secret", false, "Do not uninstall the Camel K Registry Secret in the current namespace")
 	cmd.Flags().Bool("skip-kamelets", false, "Do not uninstall the Kamelets in the current namespace")
+	cmd.Flags().Bool("skip-camel-catalogs", false, "Do not uninstall the Camel Catalogs in the current namespace")

Review Comment:
   +1 for this. Really good idea, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#issuecomment-1484701653

   Please, let me know when this is ready to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#issuecomment-1484890718

   Check failure unrelated. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] gansheer commented on pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#issuecomment-1484908022

   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4162:
URL: https://github.com/apache/camel-k/pull/4162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#discussion_r1147501437


##########
pkg/util/defaults/defaults.go:
##########
@@ -26,7 +26,7 @@ const (
 	Version = "2.0.0-SNAPSHOT"
 
 	// DefaultRuntimeVersion --
-	DefaultRuntimeVersion = "1.18.0-SNAPSHOT"
+	DefaultRuntimeVersion = "3.20.1-SNAPSHOT"

Review Comment:
   No, it's okey to keep it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org