You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 10:56:17 UTC
[GitHub] [pulsar] wenbingshen opened a new pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
wenbingshen opened a new pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506
### Motivation
Related to this PR: #10647, since version 2.8.0, the `managedLedgerNumWorkerThreads` config is not referenced anywhere.
Need to update docs?
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1055301444
@hangc0276 @codelipenghui PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1064260999
@codelipenghui @urfreespace @tuteng Could you help take a look at this pr? If this PR is accepted, I'll go ahead and submit a related PR to https://github.com/apache/pulsar-site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1066282730
> @wenbingshen The `PulsarConnectorConfig` class also has `managedLedgerNumWorkerThreads`, could you please help remove it?
Thanks for review. I have removed `managedLedgerNumWorkerThreads` from `PulsarConnectorConfig`. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen edited a comment on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen edited a comment on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1066282730
> @wenbingshen The `PulsarConnectorConfig` class also has `managedLedgerNumWorkerThreads`, could you please help remove it?
@codelipenghui Thanks for review. I have removed `managedLedgerNumWorkerThreads` from `PulsarConnectorConfig`. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1055412280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1066497166
> Do we just remove it, or do we set it to a deprecated state?
This configuration has not been `referenced` by any code since `2.8.0`,because starting from version 2.8.0, whether the user configures this parameter or not, the code will no longer take effect. So we still need to mark it as deprecated?
I think in deprecated state, this parameter needs to take effect at least in code. It is not recommended for users to use it after version 2.8.0, but we have reached version 2.11 now, and this parameter will not take effect even if it is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1064943005
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14506: remove unused config managedLedgerNumWorkerThreads and related metrics
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14506:
URL: https://github.com/apache/pulsar/pull/14506#issuecomment-1065798363
@wenbingshen The `PulsarConnectorConfig` class also has `managedLedgerNumWorkerThreads`, could you please help remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org