You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/02 06:17:44 UTC

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request, #2804: add flaky test report template

cxzl25 opened a new pull request, #2804:
URL: https://github.com/apache/incubator-kyuubi/pull/2804

   ### _Why are the changes needed?_
   Provide report flaky test report template to better track problems.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2804: add flaky test report template

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2804:
URL: https://github.com/apache/incubator-kyuubi/pull/2804#issuecomment-1145047492

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 closed pull request #2804: add flaky test report template

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #2804: add flaky test report template
URL: https://github.com/apache/incubator-kyuubi/pull/2804


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2804: add flaky test report template

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #2804:
URL: https://github.com/apache/incubator-kyuubi/pull/2804#discussion_r887619730


##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Kyuubi Flaky Test Report
+title: "Flaky Test: "
+description: Describe the flaky test you encountered with Apache Kyuubi
+labels: ["kind:bug,priority:major"]

Review Comment:
   How about this?
   ```yml
   labels: ["kind:bug,kind:test,priority:major"]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yanghua commented on a diff in pull request #2804: add flaky test report template

Posted by GitBox <gi...@apache.org>.
yanghua commented on code in PR #2804:
URL: https://github.com/apache/incubator-kyuubi/pull/2804#discussion_r887608532


##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Kyuubi Flaky Test Report
+title: "Flaky Test: "
+description: Describe the flaky test you encountered with Apache Kyuubi
+labels: ["kind:bug,priority:major"]

Review Comment:
   Can we have a `test` lable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2804: add flaky test report template

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on PR #2804:
URL: https://github.com/apache/incubator-kyuubi/pull/2804#issuecomment-1144480990

   ## Desc
   
   ![image](https://user-images.githubusercontent.com/3898450/171565506-a623ab18-356e-43de-9121-3135356ef1b8.png)
   
   ## Detail
   
   ![image](https://user-images.githubusercontent.com/3898450/171565625-ab006a96-03bc-48a0-8d6e-25e41972bfaa.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org