You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Jeff (JIRA)" <ji...@apache.org> on 2007/08/16 15:33:33 UTC
[jira] Created: (LUCENENET-76) DisjunctionMaxQuery has unnecessary
clone which causes it to fail unit tests
DisjunctionMaxQuery has unnecessary clone which causes it to fail unit tests
----------------------------------------------------------------------------
Key: LUCENENET-76
URL: https://issues.apache.org/jira/browse/LUCENENET-76
Project: Lucene.Net
Issue Type: Bug
Reporter: Jeff
Priority: Minor
DisjunctionMaxQuery.Clone() clones the DisjunctionMaxQuery then the disjuncts arraylist. When cloning the disjuncts arraylist it causes the unit tests to fail. disjuncts are cloned with cloning the query, so this is not needed.
public override System.Object Clone()
{
DisjunctionMaxQuery clone = (DisjunctionMaxQuery) base.Clone();
//clone.disjuncts = (System.Collections.ArrayList) this.disjuncts.Clone();
return clone;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-76) DisjunctionMaxQuery has unnecessary
clone which causes it to fail unit tests
Posted by "Jeff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff updated LUCENENET-76:
--------------------------
Attachment: DisjunctionMaxQuery.patch
> DisjunctionMaxQuery has unnecessary clone which causes it to fail unit tests
> ----------------------------------------------------------------------------
>
> Key: LUCENENET-76
> URL: https://issues.apache.org/jira/browse/LUCENENET-76
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Jeff
> Priority: Minor
> Attachments: DisjunctionMaxQuery.patch
>
>
> DisjunctionMaxQuery.Clone() clones the DisjunctionMaxQuery then the disjuncts arraylist. When cloning the disjuncts arraylist it causes the unit tests to fail. disjuncts are cloned with cloning the query, so this is not needed.
> public override System.Object Clone()
> {
> DisjunctionMaxQuery clone = (DisjunctionMaxQuery) base.Clone();
> //clone.disjuncts = (System.Collections.ArrayList) this.disjuncts.Clone();
> return clone;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LUCENENET-76) DisjunctionMaxQuery has unnecessary
clone which causes it to fail unit tests
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush closed LUCENENET-76.
----------------------------------
> DisjunctionMaxQuery has unnecessary clone which causes it to fail unit tests
> ----------------------------------------------------------------------------
>
> Key: LUCENENET-76
> URL: https://issues.apache.org/jira/browse/LUCENENET-76
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Jeff
> Assignee: George Aroush
> Priority: Minor
> Attachments: DisjunctionMaxQuery.patch
>
>
> DisjunctionMaxQuery.Clone() clones the DisjunctionMaxQuery then the disjuncts arraylist. When cloning the disjuncts arraylist it causes the unit tests to fail. disjuncts are cloned with cloning the query, so this is not needed.
> public override System.Object Clone()
> {
> DisjunctionMaxQuery clone = (DisjunctionMaxQuery) base.Clone();
> //clone.disjuncts = (System.Collections.ArrayList) this.disjuncts.Clone();
> return clone;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCENENET-76) DisjunctionMaxQuery has unnecessary
clone which causes it to fail unit tests
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush resolved LUCENENET-76.
------------------------------------
Resolution: Fixed
Applied patch and delivered to 2.1
> DisjunctionMaxQuery has unnecessary clone which causes it to fail unit tests
> ----------------------------------------------------------------------------
>
> Key: LUCENENET-76
> URL: https://issues.apache.org/jira/browse/LUCENENET-76
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Jeff
> Assignee: George Aroush
> Priority: Minor
> Attachments: DisjunctionMaxQuery.patch
>
>
> DisjunctionMaxQuery.Clone() clones the DisjunctionMaxQuery then the disjuncts arraylist. When cloning the disjuncts arraylist it causes the unit tests to fail. disjuncts are cloned with cloning the query, so this is not needed.
> public override System.Object Clone()
> {
> DisjunctionMaxQuery clone = (DisjunctionMaxQuery) base.Clone();
> //clone.disjuncts = (System.Collections.ArrayList) this.disjuncts.Clone();
> return clone;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (LUCENENET-76) DisjunctionMaxQuery has unnecessary
clone which causes it to fail unit tests
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush reassigned LUCENENET-76:
--------------------------------------
Assignee: George Aroush
> DisjunctionMaxQuery has unnecessary clone which causes it to fail unit tests
> ----------------------------------------------------------------------------
>
> Key: LUCENENET-76
> URL: https://issues.apache.org/jira/browse/LUCENENET-76
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Jeff
> Assignee: George Aroush
> Priority: Minor
> Attachments: DisjunctionMaxQuery.patch
>
>
> DisjunctionMaxQuery.Clone() clones the DisjunctionMaxQuery then the disjuncts arraylist. When cloning the disjuncts arraylist it causes the unit tests to fail. disjuncts are cloned with cloning the query, so this is not needed.
> public override System.Object Clone()
> {
> DisjunctionMaxQuery clone = (DisjunctionMaxQuery) base.Clone();
> //clone.disjuncts = (System.Collections.ArrayList) this.disjuncts.Clone();
> return clone;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.