You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/26 07:57:10 UTC
[GitHub] [incubator-echarts] pissang opened a new pull request #13025: [5.0] [FEATURE] Add select by brushing in dataZoom
pissang opened a new pull request #13025:
URL: https://github.com/apache/incubator-echarts/pull/13025
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
This pull request brings select by brushing interaction in dataZoom. This new interaction also includes changes in UI.
## Details
Currently this feature is enabled by default. It can be turned off by setting `brushSelect: false`.
If it's enabled, it will show an extra handle to indicate the drag zone. Here is a picture to explain the areas for different interaction.
<img width="704" alt="dataZoom-explain" src="https://user-images.githubusercontent.com/841551/88474367-3a469f80-cf58-11ea-83e1-6a3902cd6090.png">
And an interaction GIF:
### New API
```ts
dataZoom: {
brushSelect?: boolean
brushStyle?: ItemStyleOption
/**
* Icon to indicate it is a draggable panel.
*/
moveHandleIcon?: string
moveHandleStyle?: ItemStyleOption
/**
* Height of handle rect. Can be a percent string relative to the slider height.
*/
moveHandleSize?: number
emphasis: {
moveHandleStyle?: ItemStyleOption
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13025: [5.0] [FEATURE] Add select by brushing in dataZoom
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13025:
URL: https://github.com/apache/incubator-echarts/pull/13025#issuecomment-664099996
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13025: [5.0] [FEATURE] Add select by brushing in dataZoom
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13025:
URL: https://github.com/apache/incubator-echarts/pull/13025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13025: [5.0] [FEATURE] Add select by brushing in dataZoom
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13025:
URL: https://github.com/apache/incubator-echarts/pull/13025#issuecomment-663955069
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org