You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Dave Brondsema <da...@brondsema.net> on 2004/02/03 15:04:59 UTC
Re: cvs commit: xml-forrest/src/core forrest.build.xml
On Thu, 29 Jan 2004 cheche@apache.org wrote:
> Modified: . status.xml
> src/core forrest.build.xml
> Added: src/targets webapp.xml war.xml validate.xml site.xml
> Log:
> Split build file into site,validate,war,webapp
>
What's the rationale for this? Just to organize the build better? Or is
there a technical advantage too?
Would it make sense for me to put all the skin tasks into a seperate file?
Dave Brondsema
Re: cvs commit: xml-forrest/src/core forrest.build.xml
Posted by Nicola Ken Barozzi <ni...@apache.org>.
Dave Brondsema wrote:
> On Tue, 3 Feb 2004, Dave Brondsema wrote:
>
>
>>On Thu, 29 Jan 2004 cheche@apache.org wrote:
>>
>>
>>> Modified: . status.xml
>>> src/core forrest.build.xml
>>> Added: src/targets webapp.xml war.xml validate.xml site.xml
>>> Log:
>>> Split build file into site,validate,war,webapp
>>>
>>
>>What's the rationale for this? Just to organize the build better? Or is
>>there a technical advantage too?
AFAIK it's just for build organization.
>>Would it make sense for me to put all the skin tasks into a seperate file?
Yes, it would be nice.
> Looking at this more, I see a big problem:
>
> <property name="targets-dir" value="../../../src/targets"/>
>
> <import file="${targets-dir}/validate.xml"/>
> <import file="${targets-dir}/webapp.xml"/>
> <import file="${targets-dir}/war.xml"/>
> <import file="${targets-dir}/site.xml"/>
>
> When we create a distributable targets-dir won't reference an existing
> directory. The target buildfiles are not even included in the
> distributable.
Right, they should be here IMHO:
<property name="targets-dir" location="targets"/>
<import file="${targets-dir}/validate.xml"/>
<import file="${targets-dir}/webapp.xml"/>
<import file="${targets-dir}/war.xml"/>
<import file="${targets-dir}/site.xml"/>
Where:
src/core/targets webapp.xml war.xml validate.xml site.xml
^^^^^^^^
IIRC in this case the build would automatically copy them over.
--
Nicola Ken Barozzi nicolaken@apache.org
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
Re: cvs commit: xml-forrest/src/core forrest.build.xml
Posted by Dave Brondsema <da...@brondsema.net>.
On Tue, 3 Feb 2004, Dave Brondsema wrote:
>
> On Thu, 29 Jan 2004 cheche@apache.org wrote:
>
> > Modified: . status.xml
> > src/core forrest.build.xml
> > Added: src/targets webapp.xml war.xml validate.xml site.xml
> > Log:
> > Split build file into site,validate,war,webapp
> >
>
> What's the rationale for this? Just to organize the build better? Or is
> there a technical advantage too?
>
> Would it make sense for me to put all the skin tasks into a seperate file?
>
> Dave Brondsema
>
Looking at this more, I see a big problem:
<property name="targets-dir" value="../../../src/targets"/>
<import file="${targets-dir}/validate.xml"/>
<import file="${targets-dir}/webapp.xml"/>
<import file="${targets-dir}/war.xml"/>
<import file="${targets-dir}/site.xml"/>
When we create a distributable targets-dir won't reference an existing
directory. The target buildfiles are not even included in the
distributable.
--
Dave Brondsema
dave@brondsema.net
http://www.brondsema.net - personal
http://www.splike.com - programming
http://csx.calvin.edu - Calvin club
Re: cvs commit: xml-forrest/src/core forrest.build.xml
Posted by Juan Jose Pablos <ch...@che-che.com>.
Dave,
Dave Brondsema wrote:
> On Thu, 29 Jan 2004 cheche@apache.org wrote:
>> Log:
>> Split build file into site,validate,war,webapp
>
> What's the rationale for this? Just to organize the build better? Or is
> there a technical advantage too?
Just to organize better, and allow to better spot errors.
>
> Would it make sense for me to put all the skin tasks into a seperate file?
I guess that we should be creating on for each of the targets we are
able to call directly:
available-skins;
clean-site;
install-skin;
package-skin:
run ;
seed ;
site ;
validate
war
webapp
webapp-local
well, or maybe not.
WDYT?