You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/12 01:53:00 UTC
[jira] [Commented] (TAMAYA-329) PropertyConverterManager cannot box
arrays of booleans
[ https://issues.apache.org/jira/browse/TAMAYA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360212#comment-16360212 ]
ASF GitHub Bot commented on TAMAYA-329:
---------------------------------------
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/13
TAMAYA-329: mapBoxedType should work with boolean[]
Simple copy-and-paste miss. All the other primitives have both a simple
and array type check. Boolean has two simple checks and no arrays.
This corrects the copy and adds a test.
I also hit "Format" on the test class so there's a bunch of whitespace changes. I can undo that if it's stressful to anyone.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peculater/incubator-tamaya TAMAYA-329
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 47972d89b5d062495e1cd3b4fa948c73df45f95c
Author: William Lieurance <wi...@...>
Date: 2018-02-12T01:48:45Z
TAMAYA-329: mapBoxedType should work with boolean[]
Simple copy-and-paste miss. All the other primitives have both a simple
and array type check. Boolean has two simple checks and no arrays.
This corrects the copy and adds a test.
----
> PropertyConverterManager cannot box arrays of booleans
> ------------------------------------------------------
>
> Key: TAMAYA-329
> URL: https://issues.apache.org/jira/browse/TAMAYA-329
> Project: Tamaya
> Issue Type: Bug
> Reporter: William Lieurance
> Priority: Major
>
> Super simple. There's a mapBoxedType method in org.apache.tamaya.spisupport.PropertyConverterManager that lists off primitive types, then arrays of primitive types with equivalent boxed types. The second "boolean" entry didn't get array markers, so it effectively checks for straight boolean twice and boolean[] never.
> Easy patch and test on github.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)