You are viewing a plain text version of this content. The canonical link for it is here.
Posted to kandula-dev@ws.apache.org by "Katherine Sanders (JIRA)" <ji...@apache.org> on 2010/09/20 18:54:33 UTC
[jira] Created: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Performance improvement in AddressingOutHandler
-----------------------------------------------
Key: AXIS2-4824
URL: https://issues.apache.org/jira/browse/AXIS2-4824
Project: Axis2
Issue Type: Improvement
Components: Addressing
Reporter: Katherine Sanders
Priority: Minor
Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
//determine whether outbound addressing has been disabled or not.
boolean disableAddressing =
msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
to:
//determine whether outbound addressing has been disabled or not.
// Get default value from module.xml or axis2.xml files
Parameter param = msgContext.getModuleParameter(
DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
boolean disableAddressing =
msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders updated AXIS2-4824:
-------------------------------------
Attachment: AXIS2-4824.patch
This patch improves the performance and all the unit tests still pass on r998425.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikhil Thaker resolved AXIS2-4824.
----------------------------------
Resolution: Fixed
Code committed with revision # 999132.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders updated AXIS2-4824:
-------------------------------------
Attachment: AXIS2-4824.patch
This patch improves the performance and all the unit tests still pass on r998425.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Closed: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders closed AXIS2-4824.
------------------------------------
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Closed: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders closed AXIS2-4824.
------------------------------------
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikhil Thaker resolved AXIS2-4824.
----------------------------------
Resolution: Fixed
Code committed with revision # 999132.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders updated AXIS2-4824:
-------------------------------------
Attachment: AXIS2-4824.patch
This patch improves the performance and all the unit tests still pass on r998425.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders updated AXIS2-4824:
-------------------------------------
Attachment: AXIS2-4824.patch
This patch improves the performance and all the unit tests still pass on r998425.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikhil Thaker resolved AXIS2-4824.
----------------------------------
Resolution: Fixed
Code committed with revision # 999132.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikhil Thaker resolved AXIS2-4824.
----------------------------------
Resolution: Fixed
Code committed with revision # 999132.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikhil Thaker resolved AXIS2-4824.
----------------------------------
Resolution: Fixed
Code committed with revision # 999132.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Closed: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders closed AXIS2-4824.
------------------------------------
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Closed: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders closed AXIS2-4824.
------------------------------------
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders updated AXIS2-4824:
-------------------------------------
Attachment: AXIS2-4824.patch
This patch improves the performance and all the unit tests still pass on r998425.
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Closed: (AXIS2-4824) Performance improvement in
AddressingOutHandler
Posted by "Katherine Sanders (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Katherine Sanders closed AXIS2-4824.
------------------------------------
> Performance improvement in AddressingOutHandler
> -----------------------------------------------
>
> Key: AXIS2-4824
> URL: https://issues.apache.org/jira/browse/AXIS2-4824
> Project: Axis2
> Issue Type: Improvement
> Components: Addressing
> Reporter: Katherine Sanders
> Priority: Minor
> Attachments: AXIS2-4824.patch
>
>
> Revisions 631988 and 829832 added support for support for disabling the WS-Addressing outbound handler using a parameter in module.xml.
> This impacts performance in org.apache.axis2.handlers.addressing.AddressingOutHandler#invoke because the code changed from:
> //determine whether outbound addressing has been disabled or not.
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES, this.disableAddressing);
> to:
> //determine whether outbound addressing has been disabled or not.
> // Get default value from module.xml or axis2.xml files
> Parameter param = msgContext.getModuleParameter(
> DISABLE_ADDRESSING_FOR_OUT_MESSAGES, MODULE_NAME, handlerDesc);
> boolean disableAddressing =
> msgContext.isPropertyTrue(DISABLE_ADDRESSING_FOR_OUT_MESSAGES,
> JavaUtils.isTrueExplicitly(Utils.getParameterValue(param)));
> The call to MessageContext#getModuleParameter is quite expensive but this is only used to find a default value in case it is not set in the MessageContext. When there is a value in the MessageContext, the extra work is unnecessary.
> This jira should be used to reverse the logic in AddressingOutHandler so we only call getModuleParameter if the value is not set in the MessageContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org