[jira] [Commented] (SPARK-19668) Multiple NGram sizes

["Nick Pentreath (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875437#comment-15875437 ] 

Nick Pentreath commented on SPARK-19668:
----------------------------------------

I'd say a range is feasible. The current API doesn't quite fit, but we could add a further parameter that specifies the max of the range.

> Multiple NGram sizes
> --------------------
>
>                 Key: SPARK-19668
>                 URL: https://issues.apache.org/jira/browse/SPARK-19668
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.1.0
>            Reporter: Jacek KK
>            Priority: Minor
>              Labels: beginner, easyfix, newbie
>
> It would be nice to have a possibility of specyfing the range (or maybe a list of) sizes of ngrams, like it is done in sklearn, as in 
> http://scikit-learn.org/stable/modules/generated/sklearn.feature_extraction.text.TfidfVectorizer.html#sklearn.feature_extraction.text.TfidfVectorizer
> This shouldn't be difficult to add, the code is very straightforward, and I can implement it. The only issue is with the NGram API - should it just accept a number/tuple/list?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org