You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Daschinskiy (JIRA)" <ji...@apache.org> on 2018/06/22 11:29:00 UTC
[jira] [Comment Edited] (IGNITE-8820) Add ability to accept
changing txTimeoutOnPartitionMapExchange while waiting for pending
transactions.
[ https://issues.apache.org/jira/browse/IGNITE-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520224#comment-16520224 ]
Ivan Daschinskiy edited comment on IGNITE-8820 at 6/22/18 11:28 AM:
--------------------------------------------------------------------
[~ascherbakov]
1. Yes, I will add it to ExchangeFuture and explanation of my decision is below.
2. ExchangeFuture is waiting for partition release during init phase, so we are hangs in exchFut.init, before exchFut.get()
{code:java}
exchFut.init(newCrd);
int dumpCnt = 0;
final long dumpTimeout = 2 * cctx.gridConfig().getNetworkTimeout();
long nextDumpTime = 0;
while (true) {
try {
resVer = exchFut.get(dumpTimeout);
{code}
So rollback code is not neccessary at all in ExchangeManager. I'll refactor a little bit exchangeFuture init and waitForPartitionRelease to ensure that rollback logic executed once.
was (Author: ivandasch):
[~ascherbakov]
1. Yes, I will add it to ExchangeFuture and explanation is below.
2. ExchangeFuture are waiting for partition release during init phase, so we are hangs in exchFut.init, before exchFut.get()
{code:java}
exchFut.init(newCrd);
int dumpCnt = 0;
final long dumpTimeout = 2 * cctx.gridConfig().getNetworkTimeout();
long nextDumpTime = 0;
while (true) {
try {
resVer = exchFut.get(dumpTimeout);
{code}
So rollback code is not neccessary at all in ExchangeManager. I'll refactor a little bit exchangeFuture init and waitForPartitionRelease to ensure that rollback logic executed once.
> Add ability to accept changing txTimeoutOnPartitionMapExchange while waiting for pending transactions.
> ------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-8820
> URL: https://issues.apache.org/jira/browse/IGNITE-8820
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.5
> Reporter: Ivan Daschinskiy
> Assignee: Ivan Daschinskiy
> Priority: Minor
> Fix For: 2.6
>
>
> Currently, if ExchangeFuture waits whith old value of txTimeoutOnPartitionMapExchange, new value is not accepted until next exchange starts. Sometimes it's very usefull (while timeout is too long and must be shorter applied immediatelly)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)