You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/07 16:08:58 UTC

[GitHub] [incubator-devlake] likyh opened a new issue, #2112: [Bug] [config-ui] Jira saved without test connection

likyh opened a new issue, #2112:
URL: https://github.com/apache/incubator-devlake/issues/2112

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   Jira saved without test connection.
   But it tested before.
   
   
   
   ### What you expected to happen
   
   test connection as before
   
   ### How to reproduce
   
   Just look at: https://github.com/apache/incubator-devlake/blob/main/config-ui/src/hooks/useConnectionManager.jsx#L205
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2112:
URL: https://github.com/apache/incubator-devlake/issues/2112#issuecomment-1171842933

   @e2corporation Please take a look at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2112:
URL: https://github.com/apache/incubator-devlake/issues/2112#issuecomment-1200540285

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh closed issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
likyh closed issue #2112: [Bug] [config-ui] Jira saved without test connection
URL: https://github.com/apache/incubator-devlake/issues/2112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] e2corporation closed issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
e2corporation closed issue #2112: [Bug] [config-ui] Jira saved without test connection
URL: https://github.com/apache/incubator-devlake/issues/2112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh commented on issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2112:
URL: https://github.com/apache/incubator-devlake/issues/2112#issuecomment-1233660538

   jenkins and jira will not test after saving but github will. It should be regard as bug.
   
   https://github.com/apache/incubator-devlake/blob/625f8ec8fccf8b27b2d40230377fb7835ebbf637/config-ui/src/hooks/useConnectionManager.jsx#L281-L287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] e2corporation commented on issue #2112: [Bug] [config-ui] Jira saved without test connection

Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2112:
URL: https://github.com/apache/incubator-devlake/issues/2112#issuecomment-1238486300

   No this was not a bug, the only reason this was done was so that token & multi-token providers, mainly GitHub (jira and gitlab also used token field at that point) could be notified of a bad token upon entering. Github now uses a different PAT Token system that does inline-testing when the token changes, testing during save no longer needs to be done for any provider, this ticket is being closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org